Skip to content

test: added another paginate test case#48

Merged
Akalanka47000 merged 1 commit intomainfrom
test/increase-coverage
May 20, 2025
Merged

test: added another paginate test case#48
Akalanka47000 merged 1 commit intomainfrom
test/increase-coverage

Conversation

@Akalanka47000
Copy link
Copy Markdown
Member

@Akalanka47000 Akalanka47000 commented May 20, 2025

Summary by Sourcery

Tests:

  • Add test case for pagination when filters yield no documents and verify empty result metadata

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2025

Reviewer's Guide

Introduces a new paginate test case verifying behavior when filters yield no results and adds a UUID dependency to generate unique filter values.

File-Level Changes

Change Details Files
Added UUID import to support random filter generation
  • Imported "github.com/google/uuid" in test file
tests/core_read_paginate_test.go
Implemented a no‐results pagination test with filters
  • Added a Convey block titled "First page with filters (No results)"
  • Generated a filter using uuid.NewString()
  • Called Paginate(1,2) and asserted empty Docs and zero totals
  • Validated pagination flags (HasPrev, HasNext) and nil page pointers
tests/core_read_paginate_test.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Akalanka47000 Akalanka47000 merged commit e91d7c5 into main May 20, 2025
6 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Akalanka47000 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant