Add ESLint configuration and upgrade development tools#3
Merged
electerious merged 3 commits intomainfrom Sep 5, 2025
Merged
Conversation
Co-authored-by: electerious <499088+electerious@users.noreply.github.com>
Co-authored-by: electerious <499088+electerious@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ESLint and Prettier configuration with updated scripts
Add ESLint configuration and upgrade development tools
Sep 5, 2025
electerious
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the development tooling by adding ESLint configuration and upgrading the existing prettier setup, along with implementing comprehensive npm scripts for code quality checks.
Changes Made
New Dependencies
@electerious/eslint-config@^5.2.0- Provides consistent ESLint ruleseslint@^9.34.0- Core ESLint functionality@electerious/prettier-configfrom^3.0.0to^4.0.0Configuration Files
eslint.config.js- Exports the Electerious ESLint configurationUpdated npm Scripts
Replaced and added scripts for comprehensive code quality workflow:
{ "eslint": "eslint \"**/*.js\"", "format": "npm run eslint -- --fix && npm run prettier -- --write", "lint": "npm run eslint && npm run prettier -- --check", "prettier": "prettier --ignore-path .gitignore \"**/*.{js,json,md,yml}\"", "test": "npm run lint && node --test" }The
startscript was preserved as requested.Code Quality Improvements
Applied ESLint auto-fixes and manual corrections to resolve:
node:http,node:crypto, etc.)Number.isNaN()over globalisNaN()process.exit()with proper error throwingCompatibility Fixes
Promise.withResolvers()with manual Promise construction for Node.js v20 compatibilityWorkflow Impact
The new scripts provide a complete development workflow:
npm run lint- Checks code style and quality without making changesnpm run format- Automatically fixes all auto-fixable issuesnpm test- Runs linting + prettier checks + Node.js testsnpm run eslint- Runs only ESLint checksnpm run prettier- Runs only Prettier checksAll scripts now pass successfully, ensuring consistent code quality across the project.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.