404 on states with two spaces, or special chars like ñ

[fede2cr]

While testing the PyPortal with places that have 3 words (2 spaces) or at least this special character ñ but maybe more.

Space example: In this case, it looks like only the first space was converted to _
https://electioncal.us/en/california/san_luis%20obispo

In this case the character ñ is translated to this ã±
https://electioncal.us/en/new_mexico/do%C3%A3%C2%B1a_ana

[fede2cr]

Some other examples:
https://electioncal.us/en/alaska/yukon-koyukuk
https://electioncal.us/en/alaska/valdez-cordova
https://electioncal.us/en/alaska/lake_and%20peninsula
https://electioncal.us/en/alaska/hoonah-angoon

[tannewt]

Where are you getting these links? Selecting them from the state page works ok.

[fede2cr]

Clicking on the map at random.

[askpatrickw]

I'll take a look at this

[askpatrickw]

The names in the JSON which makes the map work, does not match our path layout.
Source JSON: https://cdn.jsdelivr.net/npm/us-atlas@3/counties-10m.json

Navigating via the the drop-downs work.

@tannewt Is there any issue with pulling that file in our repo and then editing it?
Or would you prefer to align our layout to their naming? If they change it could break us though.

[askpatrickw]

OK this was a tiny bit more complicated than I had hoped There are several classes of issue and different
fixes for each. Below is what I found and what I propose we do about it.

For these items, I recommend we change ElectionCal's folder names and drop-downs to match the JSON.
I think the JSON names are the more familiar name.
Note: It might also be possible the "Census" areas don't have any "county" elections because they are state
governed... I did not check this.

ELECTIONCAL_FIXES = [
    {"state`": "`alaska", "county_id": "02275", "json_name": "wrangell", "current_path_name": "wrangell_city_and"},
    {"state": "alaska", "county_id": "02158", "json_name": "kusilvak", "current_path_name": "kusilvak_census"},
    {"state": "alaska", "county_id": "02105", "json_name": "hoonah-angoon", "current_path_name": "hoonah-angoon_census"},
    {"state": "alaska", "county_id": "02261", "json_name": "valdez-cordova", "current_path_name": "valdez-cordova_census"},
    {"state": "alaska", "county_id": "02290", "json_name": "yukon-koyukuk", "current_path_name": "yukon-koyukuk_census"},
    {"state": "alaska", "county_id": "02240", "json_name": "southeast_fairbanks", "current_path_name": "southeast_fairbanks_census"},
    {"state": "alaska", "county_id": "02198", "json_name": "prince_of_wales-hyder", "current_path_name": "prince_of_wales-hyder_census"},
    {"state": "alaska", "county_id": "02220", "json_name": "sitka", "current_path_name": "sitka_city_and"},
    {"state": "alaska", "county_id": "02050", "json_name": "bethel", "current_path_name": "bethel_census"},
    {"state": "alaska", "county_id": "02070", "json_name": "dillingham", "current_path_name": "dillingham_census"},
    {"state": "alaska", "county_id": "02282", "json_name": "yakutat", "current_path_name": "yakutat_city_and"},
    {"state": "alaska", "county_id": "02110", "json_name": "juneau", "current_path_name": "juneau_city_and"},
    {"state": "alaska", "county_id": "02016", "json_name": "aleutians_west", "current_path_name": "aleutians_west_census"},
    {"state": "alaska", "county_id": "02180", "json_name": "nome", "current_path_name": "nome_census"},
    {"state": "nevada", "county_id": "32510", "json_name": "carson_city", "current_path_name": "carson"},
]

For these items, I recommend we change the JSON to have the proper Unicode characters.
I assume JS is fine with that.

FIX_JSON = [
    {"state": "new_mexico", "county_id": "35013", "json_name": "doã±a_ana", "current_path_name": "doña_ana"},
    {"state": "puerto_rico", "county_id": "72033", "json_name": "cataã±o", "current_path_name": "cataño"},
    {"state": "puerto_rico", "county_id": "72117", "json_name": "rincã³n", "current_path_name": "rincón"},
    {"state": "puerto_rico", "county_id": "72029", "json_name": "canã³vanas", "current_path_name": "canóvanas"},
    {"state": "puerto_rico", "county_id": "72045", "json_name": "comerã\xado", "current_path_name": "comerío"},
    {"state": "puerto_rico", "county_id": "72075", "json_name": "juana_dã\xadaz", "current_path_name": "juana_díaz"},
    {"state": "puerto_rico", "county_id": "72087", "json_name": "loã\xadza", "current_path_name": "loíza"},
    {"state": "puerto_rico", "county_id": "72125", "json_name": "san_germã¡n", "current_path_name": "san_germán"},
    {"state": "puerto_rico", "county_id": "72119", "json_name": "rã\xado_grande", "current_path_name": "río_grande"},
    {"state": "puerto_rico", "county_id": "72131", "json_name": "san_sebastiã¡n", "current_path_name": "san_sebastián"},
    {"state": "puerto_rico", "county_id": "72055", "json_name": "guã¡nica", "current_path_name": "guánica"},
    {"state": "puerto_rico", "county_id": "72011", "json_name": "aã±asco", "current_path_name": "añasco"},
    {"state": "puerto_rico", "county_id": "72097", "json_name": "mayagã¼ez", "current_path_name": "mayagüez"},
    {"state": "puerto_rico", "county_id": "72083", "json_name": "las_marã\xadas", "current_path_name": "las_marías"},
    {"state": "puerto_rico", "county_id": "72111", "json_name": "peã±uelas", "current_path_name": "peñuelas"},
    {"state": "puerto_rico", "county_id": "72021", "json_name": "bayamã³n", "current_path_name": "bayamón"},
    {"state": "puerto_rico", "county_id": "72091", "json_name": "manatã\xad", "current_path_name": "manatí"}
]

For these items, we don't have any county folders. I recommend we add them.

NO_COUNTIES =[
    {"state": "american_samoa", "county_id": "60020", "json_name': "manu'a", "current_path_name": ""},
    {"state": "american_samoa", "county_id": "60050", "json_name": "western", "current_path_name": ""},
    {"state": "american_samoa", "county_id": "60010", "json_name": "eastern", "current_path_name": ""},
    {"state": "district_of_columbia", "county_id": "11001", "json_name": "district_of_columbia", "current_path_name": ""},
    {"state": "guam", "county_id": "66010", "json_name": "guam", "current_path_name": ""},
]

For these items, the state name is different in ElectionCal AND we don't have the counties.
I recommend we change the JSON for commonwealth_of_the_northern_mariana_islands to northern_mariana_islands.
I recommend we change ElectionCal folder name and drop-down to united_states_virgin_islands.
I recommend we we add the counties for both.

STATE_WRONG_AND_NO_COUNTIES = [
    {"state": "commonwealth_of_the_northern_mariana_islands", "county_id": "69110", "json_name": "saipan", "current_path_name": ""},
    {"state": "commonwealth_of_the_northern_mariana_islands", "county_id": "69120", "json_name": "tinian", "current_path_name": ""},
    {"state": "commonwealth_of_the_northern_mariana_islands", "county_id": "69085", "json_name": "northern_islands", "current_path_name": ""},
    {"state": "commonwealth_of_the_northern_mariana_islands", "county_id": "69100", "json_name": "rota", "current_path_name": ""},
    {"state": "united_states_virgin_islands", "county_id": "78030", "json_name": "st._thomas", "current_path_name": ""},
    {"state": "united_states_virgin_islands", "county_id": "78010", "json_name": "st._croix", "current_path_name": ""},
    {"state": "united_states_virgin_islands", "county_id": "78020", "json_name": "st._john", "current_path_name": ""}
]

[askpatrickw]

I should show my work...
This is how I came up with all that...

from os import path
from operator import itemgetter
import json

USATLASS_JSON = "../site/static/counties-10m.json"
with open(USATLASS_JSON, "r") as f:
    state_county_json = json.load(f)

states = state_county_json['objects']['states']['geometries']
counties = state_county_json['objects']['counties']['geometries']
four_oh_fours = []

for county in counties:
    county_name = county['properties']['name'].lower().replace(' ', '_')
    state_name = next((state for state in states if state['id'] == county['id'][:2]))['properties']['name'].lower().replace(' ', '_')
    if not path.exists(f'../site/en/{state_name}/{county_name}'):
        four_oh_fours.append({
            "state": state_name,
            "county_id": county['id'],
            "json_name": county_name,
            "current_path_name": "",
            "what_to_change": "", # Folder or JSON
            "recommended_name": ""
            })
four_oh_fours = sorted(four_oh_fours, key=itemgetter('state')) 
print(four_oh_fours)

[tannewt]

@askpatrickw Thanks for the detailed look! The changes sound good to me. Better to improve this now. Not that virginia has some weird named "X city" county names because they are both a city and a county. Looks like those are fine though.

[askpatrickw]

Remaining work

The list below are the only known areas which don't have county folders.
All of them are protectorates with the exception of D.C. which does not have counties.

I suggest the Map or the Click events be fixed so you can't click a county for them.

• It is possible (but next to impossible) to click DC and the county of DC.
• It is not possible with the others. They are not on the map.

[
{'state': 'american_samoa', 'county_id': '60020', 'json_name': "manu'a", 'current_path_name': ''},
{'state': 'american_samoa', 'county_id': '60050', 'json_name': 'western', 'current_path_name': ''},
{'state': 'american_samoa', 'county_id': '60010', 'json_name': 'eastern', 'current_path_name': ''},
{'state': 'district_of_columbia', 'county_id': '11001', 'json_name': 'district_of_columbia', 'current_path_name': ''},
{'state': 'guam', 'county_id': '66010', 'json_name': 'guam', 'current_path_name': ''},
{'state': 'northern_mariana_islands', 'county_id': '69110', 'json_name': 'saipan', 'current_path_name': ''},
{'state': 'northern_mariana_islands', 'county_id': '69120', 'json_name': 'tinian', 'current_path_name': ''},
{'state': 'northern_mariana_islands', 'county_id': '69085', 'json_name': 'northern_islands', 'current_path_name': ''},
{'state': 'northern_mariana_islands', 'county_id': '69100', 'json_name': 'rota', 'current_path_name': ''},
{'state': 'united_states_virgin_islands', 'county_id': '78030', 'json_name': 'st._thomas', 'current_path_name': ''},
{'state': 'united_states_virgin_islands', 'county_id': '78010', 'json_name': 'st._croix', 'current_path_name': ''},
{'state': 'united_states_virgin_islands', 'county_id': '78020', 'json_name': 'st._john', 'current_path_name': ''}
]