Skip to content

Conversation

@kevin-dp
Copy link
Contributor

@kevin-dp kevin-dp commented Dec 19, 2024

This PR contains the necessary SST config for deploying the Phoenix liveview example to the cloud.

@balegas balegas mentioned this pull request May 5, 2025
3 tasks
@kevin-dp kevin-dp force-pushed the kevin/phoenix-liveview-deployment branch from 4e5d01d to 57c05ad Compare May 13, 2025 08:21
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

@kevin-dp kevin-dp closed this May 13, 2025
@kevin-dp kevin-dp reopened this May 13, 2025
@kevin-dp kevin-dp closed this May 13, 2025
Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks for doing that. Think the sst code could do with some cleanup though

const { pooledDatabaseUri, sourceId, sourceSecret } =
createDatabaseForCloudElectric({
dbName,
migrationsDirectory: `./db/migrations`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird having the whole phoenix/ecto migration machinery and then just using this... but understand that this is maybe all we need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, but this is a common pattern across all examples. So best to keep it for now.

@codecov
Copy link

codecov bot commented May 20, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2095 1 2094 974
View the top 1 failed test(s) by shortest run time
Elixir.Electric.Shapes.ConsumerTest::test transaction handling with real storage restarting a consumer doesn't lower the last known offset when only snapshot is present
Stack Traces | 0s run time
5) test transaction handling with real storage restarting a consumer doesn't lower the last known offset when only snapshot is present (Electric.Shapes.ConsumerTest)
     .../electric/shapes/consumer_test.exs:869
     ** (EXIT from #PID<0.5962.0>) an exception was raised:
         ** (ArgumentError) errors were found at the given arguments:

       * 1st argument: table name already exists

             (stdlib 6.2) :ets.new(:"Elixir.Electric.Shapes.ConsumerTest test transaction handling with real storage restarting a consumer doesn't lower the last known offset when only snapshot is present:lsn_tracker", [:protected, :named_table])
             (electric 1.0.13) lib/electric/lsn_tracker.ex:34: Electric.LsnTracker.create_table/1
             (electric 1.0.13) lib/electric/lsn_tracker.ex:5: Electric.LsnTracker.init/2
             (electric 1.0.13) .../electric/replication/shape_log_collector.ex:133: Electric.Replication.ShapeLogCollector.handle_call/3
             (gen_stage 1.2.1) lib/gen_stage.ex:1942: GenStage.handle_call/3
             (stdlib 6.2) gen_server.erl:2381: :gen_server.try_handle_call/4
             (stdlib 6.2) gen_server.erl:2410: :gen_server.handle_msg/6
             (stdlib 6.2) proc_lib.erl:329: :proc_lib.init_p_do_apply/3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@kevin-dp kevin-dp merged commit 0908c53 into main May 20, 2025
26 of 28 checks passed
@kevin-dp kevin-dp deleted the kevin/phoenix-liveview-deployment branch May 20, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants