-
Notifications
You must be signed in to change notification settings - Fork 295
chore (examples): cloud deployment of the phoenix liveview example #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bf717a9 to
4f03c45
Compare
4e5d01d to
57c05ad
Compare
Examples
|
magnetised
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thanks for doing that. Think the sst code could do with some cleanup though
| const { pooledDatabaseUri, sourceId, sourceSecret } = | ||
| createDatabaseForCloudElectric({ | ||
| dbName, | ||
| migrationsDirectory: `./db/migrations`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird having the whole phoenix/ecto migration machinery and then just using this... but understand that this is maybe all we need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, but this is a common pattern across all examples. So best to keep it for now.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This PR contains the necessary SST config for deploying the Phoenix liveview example to the cloud.