Skip to content

Conversation

@alco
Copy link
Member

@alco alco commented Jan 20, 2026

Summary

  • Add .github/workflows/sync_service_tests.yml to the workflow's path triggers
  • Ensures the sync-service tests run when the workflow file itself is modified

Summary by CodeRabbit

  • Chores
    • Updated internal workflow configuration for testing processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

📝 Walkthrough

Walkthrough

Modified the GitHub Actions workflow to include self-referential path filters, allowing the workflow file itself to trigger workflow runs when changes are pushed or pull requested. This enables the workflow to automatically re-run when the workflow configuration is modified.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
\.github/workflows/sync_service_tests\.yml
Added workflow file path to push and pull_request path filters, enabling self-triggered runs on workflow file modifications

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • balegas

Poem

🐰 A workflow that watches itself with care,
Self-referential paths float through the air,
When changes arrive to the workflow's own line,
The runner awakens—a loop so divine!
Trigger within trigger, where logic runs fine ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a self-referential trigger to the workflow so it runs when the workflow file itself is modified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2788195 and 7b4f5d8.

📒 Files selected for processing (1)
  • .github/workflows/sync_service_tests.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Test packages/start w/ sync-service
  • GitHub Check: Test packages/typescript-client w/ sync-service
  • GitHub Check: Test packages/react-hooks w/ sync-service
  • GitHub Check: Test packages/y-electric w/ sync-service
  • GitHub Check: Build and test sync-service, pg18
  • GitHub Check: Build and test sync-service, pg14
  • GitHub Check: Run Lux integration tests
  • GitHub Check: Build and test sync-service, pg17
  • GitHub Check: Build and test sync-service, pg15
🔇 Additional comments (1)
.github/workflows/sync_service_tests.yml (1)

9-14: Good addition to path filters.

This correctly triggers the workflow when its own file changes, matching the intent.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@msfstef msfstef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, might be worth doing the same for the postgres build workflow (rebuild postres when the yml is updated?)

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (2788195) to head (7b4f5d8).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3743   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files          23       23           
  Lines        2011     2011           
  Branches      532      532           
=======================================
  Hits         1757     1757           
  Misses        252      252           
  Partials        2        2           
Flag Coverage Δ
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 93.47% <ø> (ø)
packages/y-electric 56.05% <ø> (ø)
typescript 87.36% <ø> (ø)
unit-tests 87.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blacksmith-sh

This comment has been minimized.

@alco
Copy link
Member Author

alco commented Jan 20, 2026

@msfstef That workflow runs on a cron schedule. Are you suggesting adding another push trigger? I think one can be added temporarily for testing when making changes there. The purpose of the workflow is to run in background, not be associated with any specific commit in the repo.

@msfstef
Copy link
Contributor

msfstef commented Jan 20, 2026

@alco having a workflow trigger as well would be good so we can fix itwhen we want - e.g. now lots of tests are failing because of the limit on max connections, lt's not wait for the cron job!

edit: already has it - ignore me!

@alco
Copy link
Member Author

alco commented Jan 20, 2026

@msfstef I have rebuilt the Postgres image and rerun Elixir tests. All green now.

@alco alco merged commit 462e917 into main Jan 20, 2026
44 of 48 checks passed
@alco alco deleted the ci/trigger-sync-service-tests-on-workflow-change branch January 20, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants