-
Notifications
You must be signed in to change notification settings - Fork 300
ci(sync-service): trigger workflow when workflow file is modified #3743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughModified the GitHub Actions workflow to include self-referential path filters, allowing the workflow file itself to trigger workflow runs when changes are pushed or pull requested. This enables the workflow to automatically re-run when the workflow configuration is modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Comment |
msfstef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, might be worth doing the same for the postgres build workflow (rebuild postres when the yml is updated?)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3743 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 23 23
Lines 2011 2011
Branches 532 532
=======================================
Hits 1757 1757
Misses 252 252
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
@msfstef That workflow runs on a cron schedule. Are you suggesting adding another push trigger? I think one can be added temporarily for testing when making changes there. The purpose of the workflow is to run in background, not be associated with any specific commit in the repo. |
|
@alco having a workflow trigger as well would be good so we can fix itwhen we want - e.g. now lots of tests are failing because of the limit on max connections, lt's not wait for the cron job! edit: already has it - ignore me! |
|
@msfstef I have rebuilt the Postgres image and rerun Elixir tests. All green now. |
Summary
.github/workflows/sync_service_tests.ymlto the workflow's path triggersSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.