Skip to content

Alco/write txn fragments to storage#3783

Draft
alco wants to merge 19 commits intomainfrom
alco/write-txn-fragments-to-storage
Draft

Alco/write txn fragments to storage#3783
alco wants to merge 19 commits intomainfrom
alco/write-txn-fragments-to-storage

Conversation

@alco
Copy link
Member

@alco alco commented Jan 27, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Jan 27, 2026

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 1c882c2
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/6979f08216c1c700088bcf13
😎 Deploy Preview https://deploy-preview-3783--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jan 27, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2140 1 2139 0
View the top 1 failed test(s) by shortest run time
test/client.test.ts > should fall back to long polling after 3 consecutive short SSE connections
Stack Traces | 0.215s run time
AssertionError: expected 5 to be less than or equal to 4
 ❯ test/client.test.ts:2680:37
View the full list of 1 ❄️ flaky test(s)
Elixir.Electric.ShapeCacheTest::test get_or_create_shape_handle/2 against real db crashes when initial snapshot query fails to return data quickly enough

Flake rate in main: 35.29% (Passed 11 times, Failed 6 times)

Stack Traces | 0s run time
13) test get_or_create_shape_handle/2 against real db crashes when initial snapshot query fails to return data quickly enough (Electric.ShapeCacheTest)
     test/electric/shape_cache_test.exs:501
     ** (EXIT from #PID<0.12457.0>) killed

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Jan 27, 2026

Found 2 test failures on Blacksmith runners:

Failures

Test View Logs
Elixir.Electric.ShapeCacheTest/test get_or_create_shape_handle/
2 against real db crashes when initial snapshot query fails to return data quickly enou
gh
View Logs
test/client.test.ts/
should fall back to long polling after 3 consecutive short SSE connections
View Logs

Fix in Cursor

alco added 19 commits January 28, 2026 12:15
This latter function needs to see converted changes to correectly notify
subscribed materializers
@alco alco force-pushed the alco/write-txn-fragments-to-storage branch from d3dc0f4 to 1c882c2 Compare January 28, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant