Skip to content

fix(sync-service): Ignore failure to rollback#3939

Merged
magnetised merged 1 commit intomainfrom
magnetised/ignore-failure-to-rollback
Mar 3, 2026
Merged

fix(sync-service): Ignore failure to rollback#3939
magnetised merged 1 commit intomainfrom
magnetised/ignore-failure-to-rollback

Conversation

@magnetised
Copy link
Contributor

@magnetised magnetised commented Mar 3, 2026

Ignore result of attempting to rollback a write transaction.

Errors may happen after the txn has already been committed (or aborted) so we can ignore any errors resulting from any secondary ROLLBACK.

Helps with #3943

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.77%. Comparing base (b4be560) to head (985c6a8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3939   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files          25       25           
  Lines        2415     2415           
  Branches      609      605    -4     
=======================================
  Hits         2144     2144           
  Misses        269      269           
  Partials        2        2           
Flag Coverage Δ
packages/experimental 87.73% <ø> (ø)
packages/react-hooks 86.48% <ø> (ø)
packages/start 82.83% <ø> (ø)
packages/typescript-client 94.01% <ø> (ø)
packages/y-electric 56.05% <ø> (ø)
typescript 88.77% <ø> (ø)
unit-tests 88.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blacksmith-sh

This comment has been minimized.

@magnetised magnetised force-pushed the magnetised/ignore-failure-to-rollback branch from 0ae0257 to 985c6a8 Compare March 3, 2026 10:31
@magnetised magnetised merged commit 9ea6a31 into main Mar 3, 2026
52 of 55 checks passed
@magnetised magnetised deleted the magnetised/ignore-failure-to-rollback branch March 3, 2026 10:42
@noudadrichem
Copy link

Legends!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

This PR has been released! 🚀

The following packages include changes from this PR:

  • @core/sync-service@1.4.12

Thanks for contributing to Electric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants