feat(sync-service): Add ELECTRIC_EXCLUDE_SPANS env var#3952
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3952 +/- ##
=======================================
Coverage 88.77% 88.77%
=======================================
Files 25 25
Lines 2415 2415
Branches 606 604 -2
=======================================
Hits 2144 2144
Misses 269 269
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robacourt
force-pushed
the
rob/less-spans
branch
from
b70a6b9 to
1b43f15
Compare
Allow excluding arbitrary OTel spans by name via a comma-separated env var, helping manage telemetry quota usage with providers like Honeycomb. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
robacourt
force-pushed
the
rob/less-spans
branch
from
1b43f15 to
3934255
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
Looks good to me, but needs a elixir dev review |
Contributor
|
This PR has been released! 🚀 The following packages include changes from this PR:
Thanks for contributing to Electric! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a general-purpose
ELECTRIC_EXCLUDE_SPANSenvironment variable that allows excluding arbitrary OTel spans by name via a comma-separated list, helping manage telemetry quota usage with providers like Honeycomb.Changes
ELECTRIC_EXCLUDE_SPANSinconfig/runtime.exsinto aMapSetof span namesElectric.Telemetry.Samplerthat gates span creation before existingfilter.*andpg_txn.*rulesexclude_spans: MapSet.new()default inElectric.ConfigUsage
ELECTRIC_EXCLUDE_SPANS="shape_status.validate_shape_handle,shape_get.api.load_shape_info"Test Plan
ELECTRIC_EXCLUDE_SPANSand confirm excluded spans are no longer createdGenerated with Claude Code