Skip to content

Remove unused agents error stream#4516

Merged
KyleAMathews merged 17 commits into
mainfrom
remove-agent-error-stream
Jun 5, 2026
Merged

Remove unused agents error stream#4516
KyleAMathews merged 17 commits into
mainfrom
remove-agent-error-stream

Conversation

@KyleAMathews
Copy link
Copy Markdown
Contributor

Summary

  • remove the per-entity agents error stream from spawn, fork, registry lookup, and terminal signal handling
  • simplify public/runtime/UI entity stream types to expose only the main stream
  • update conformance tests, unit fixtures, helpers, and changelog references to stop requiring an error stream

Verification

  • ./scripts/dev.sh build
  • rg audit for remaining real error-stream references (only unrelated form error copy remains)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Electric Agents Desktop Builds

Build artifacts for commit e60e30a.

Platform Status Artifact
macOS Apple Silicon Passed DMG
macOS Intel Passed DMG
Windows x64 Passed Installer
Linux x64 Passed AppImage / deb

Workflow run

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.65%. Comparing base (7c62024) to head (e60e30a).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4516      +/-   ##
==========================================
+ Coverage   55.62%   55.65%   +0.03%     
==========================================
  Files         300      300              
  Lines       33945    33928      -17     
  Branches     9636     9634       -2     
==========================================
+ Hits        18882    18884       +2     
+ Misses      15044    15025      -19     
  Partials       19       19              
Flag Coverage Δ
packages/agents 71.78% <ø> (ø)
packages/agents-mobile 84.09% <ø> (ø)
packages/agents-runtime 80.97% <ø> (+0.11%) ⬆️
packages/agents-server 72.75% <100.00%> (-0.04%) ⬇️
packages/agents-server-ui 5.77% <ø> (ø)
packages/electric-ax 46.42% <ø> (ø)
typescript 55.65% <100.00%> (+0.03%) ⬆️
unit-tests 55.65% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

Electric Agents Mobile Build

Local mobile checks ran for commit e60e30a.

The EAS Android preview build was skipped because the mobile-eas-build label is not present.
Add the mobile-eas-build label to this PR to produce an installable preview build.

Workflow run

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 5, 2026

Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit e60e30a
🔍 Latest deploy log https://app.netlify.com/projects/electric-next/deploys/6a22fd2a698186000806f4d2
😎 Deploy Preview https://deploy-preview-4516--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@KyleAMathews KyleAMathews merged commit d14d9a9 into main Jun 5, 2026
42 checks passed
@KyleAMathews KyleAMathews deleted the remove-agent-error-stream branch June 5, 2026 17:12
kevin-dp added a commit that referenced this pull request Jun 8, 2026
Main commits absorbed during the rebase changed assumptions our PR
relied on:

- #4517 removed `.run` / `.text` from EntityHandle and `resolveRun` /
  `rejectRun` from SpawnHandleInfo. Strip those from the fork handle
  in setup-context.ts so it matches the simplified spawn shape.
- Forks now get a `createdBy` field on `forkSubtree` calls; update the
  route test expectation accordingly.
- #4516 removed the per-entity `error` stream; drop it from the fork
  rollback test's deleted-streams expectation.
- Add the missing `doFork` mock to two `createHandlerContext` test
  configs in context-factory.test.ts.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants