Bugfix/emcb 106 bugfixes and improvements#79
Merged
betzrhodes merged 1 commit intoelectricimp:developfrom Mar 18, 2020
Merged
Conversation
vadim-galeev
force-pushed
the
bugfix/EMCB-106-bugfixes-and-improvements
branch
from
e6fa716 to
b672ce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug in FileCache related to
contextvariable.includePathParsedvariable was getting a wrong value while reading a cached file, now it's fixed.includePathParsedvariable was taking a wrong value if the readable file was cached, because the string what had been moved to another place was after this place (in this placeincludePathis changing).It is related to
context, becausefileCache.read()returnsincludePathParsedtogether with thecontext, andincludePathParsedthen becomes a part ofcontext. See here.The bug was fixed by moving the string to another place.
A test is added into context.spec.js to check this issue. Some log messages changed.