p;arsing error fix from mysticpants develop branch#2
Merged
betzrhodes merged 5 commits intoelectricimp:developfrom Aug 24, 2017
Merged
p;arsing error fix from mysticpants develop branch#2betzrhodes merged 5 commits intoelectricimp:developfrom
betzrhodes merged 5 commits intoelectricimp:developfrom
Conversation
Docs updated
A new test case was written for it 2. Added notes to advise users of the TCP connection dropout after a certain amount of idle time 3. Added notes to inform users that the order of operation in readWriteMultipleRegisters may differ from the modus spec in reality .
# Conflicts: # ModbusTCPMaster/README.md
Author
|
This fix seems to be on mystic pants branch but not ours. Changes look like they fix the issue filed when we reviewed the library, but never got bubbled up to our repo. |
Author
|
when library update is available we should update this forum post. |
ppetrosh
reviewed
Aug 23, 2017
| Function Code : 23 | ||
|
|
||
| This method performs a combination of one read operation and one write operation in a single Modbus transaction. The write operation is performed before the read. It takes the following parameters: | ||
| This method performs a combination of one read operation and one write operation in a single Modbus transaction. The write operation is performed before the read ^. It takes the following parameters: |
ppetrosh
reviewed
Aug 23, 2017
| Function Code : 23 | ||
|
|
||
| This method performs a combination of one read operation and one write operation in a single Modbus transaction. The write operation is performed before the read. It takes the following parameters: | ||
| This method performs a combination of one read operation and one write operation in a single Modbus transaction. The write operation is performed before the read ^. It takes the following parameters: |
ppetrosh
reviewed
Aug 23, 2017
ppetrosh
left a comment
ppetrosh
left a comment
There was a problem hiding this comment.
Looks good to me except for the two minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.