Array and string offset access syntax with curly braces is deprecated

[n1c]

Not sure if there are more examples of it; but this triggered in my app! The change makes it supported by PHP 7.4.

[OneCodeMonkey]

This repo seems nobody maintains, php version is too old.
And because of many static variables usage, it has an memory leak risk.

[caramboleyo]

@OneCodeMonkey

This repo seems nobody maintains, php version is too old. And because of many static variables usage, it has an memory leak risk.

Why is the use of static variables a memory leak risk?

[valerio-bozzolan]

Just as a note, this fix was resolved also in this fork (that seems more updated):

https://github.com/rubobaquero/phpquery

[reedy]

Wonder if this one should've changed...

[electrolinux]

Nice catch, in fact.
At first, it doesn't bother me as I was no longer using (nor really maintaining) this package, but as it is still the first one shown when requesting phpquery at packagist.org, it seems @n1c should not have changed this unless also taking care of the packagist repo...

@reedy, do you have a clue as to how to make some advertising in package.json to tell people requiring it that this package need a new maintainer ?
Are you interested ?

[reedy]

If you visit https://packagist.org/packages/electrolinux/phpquery when logged in as the maintainer/owner of the package, you can hit abandon which will make it fairly obvious. You can un-abandon it later...

It does seem some forks like https://packagist.org/packages/rubobaquero/phpquery are more actively maintained though

[n1c]

Yeah this is definitely bad. Sorry about the confusion caused!

I think it was because I was using my own fork under that namespace, but it shouldn't have gone into the PR to get merged back into this repo.

[electrolinux]

Don't worry, I'm the one that merged this PR! :)
And we often learn more from our mistakes than from our successes...

[reedy]

Not a big deal when there's been no release with it.. yet ;)

#19 reverts the offending commit.