feat(): search for react-script in package dependencies as well as devDependencies

Close #2532

Author: develar

packages/electron-builder-lib/src/configuration.ts

@@ -142,7 +142,7 @@ export interface Configuration extends PlatformSpecificBuildOptions {
   /**
    * The name of a built-in configuration preset or path to config file (relative to project dir). Currently, only `react-cra` is supported.
    *
-   * If `react-scripts` in the app dev dependencies, `react-cra` will be set automatically. Set to `null` to disable automatic detection.
+   * If `react-scripts` in the app dependencies, `react-cra` will be set automatically. Set to `null` to disable automatic detection.
    */
   extends?: string | null
 

packages/electron-builder-lib/src/util/config.ts

@@ -46,16 +46,16 @@ export async function getConfig(projectDir: string, configPath: string | null, c
 
   let extendsSpec = config.extends
   if (extendsSpec == null && extendsSpec !== null) {
-    const devDependencies = (await packageMetadata.value || {}).devDependencies
-    if (devDependencies != null) {
-      if ("react-scripts" in devDependencies) {
-        extendsSpec = "react-cra"
-        config.extends = extendsSpec
-      }
-      else if ("electron-webpack" in devDependencies) {
-        extendsSpec = "electron-webpack/electron-builder.yml"
-        config.extends = extendsSpec
-      }
+    const metadata = await packageMetadata.value || {}
+    const devDependencies = metadata.devDependencies
+    const dependencies = metadata.dependencies
+    if ((dependencies != null && "react-scripts" in dependencies) || (devDependencies != null && "react-scripts" in devDependencies)) {
+      extendsSpec = "react-cra"
+      config.extends = extendsSpec
+    }
+    else if (devDependencies != null && "electron-webpack" in devDependencies) {
+      extendsSpec = "electron-webpack/electron-builder.yml"
+      config.extends = extendsSpec
     }
   }