fix: unpack node module if there is dylib file

develar · develar · commit daf6f590eb19 · 2018-03-09T13:39:10.000+01:00
Close #2635
diff --git a/packages/electron-builder-lib/src/asar/unpackDetector.ts b/packages/electron-builder-lib/src/asar/unpackDetector.ts
@@ -75,8 +75,9 @@ export async function detectUnpackedDirs(fileSet: ResolvedFileSet, autoUnpackDir
       continue
     }
 
+    // https://github.com/electron-userland/electron-builder/issues/2679
     let shouldUnpack = false
-    if (file.endsWith(".dll") || file.endsWith(".exe")) {
+    if (file.endsWith(".dll") || file.endsWith(".exe") || file.endsWith(".dylib")) {
       shouldUnpack = true
     }
     else if (!file.includes(".", nextSlashIndex) && path.extname(file) === "") {

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,9 @@ export async function detectUnpackedDirs(fileSet: ResolvedFileSet, autoUnpackDir`
`75`	`75`	`continue`
`76`	`76`	`}`
`77`	`77`
	`78`	`+ // https://github.com/electron-userland/electron-builder/issues/2679`
`78`	`79`	`let shouldUnpack = false`
`79`		`- if (file.endsWith(".dll") \|\| file.endsWith(".exe")) {`
	`80`	`+ if (file.endsWith(".dll") \|\| file.endsWith(".exe") \|\| file.endsWith(".dylib")) {`
`80`	`81`	`shouldUnpack = true`
`81`	`82`	`}`
`82`	`83`	`else if (!file.includes(".", nextSlashIndex) && path.extname(file) === "") {`