Skip to content

Commit f799062

Browse files
committed
fix(snap): Snap builds do not have architectures key
Close #2596
1 parent 24f2565 commit f799062

File tree

7 files changed

+162
-130
lines changed

7 files changed

+162
-130
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
"////": "All typings are added into root `package.json` to avoid duplication errors in the IDE compiler (several `node.d.ts` files).",
3030
"dependencies": {
3131
"7zip-bin": "~3.1.0",
32-
"app-builder-bin": "1.3.5",
32+
"app-builder-bin": "1.3.6",
3333
"archiver": "^2.1.1",
3434
"async-exit-hook": "^2.0.1",
35-
"aws-sdk": "^2.197.0",
35+
"aws-sdk": "^2.198.0",
3636
"bluebird-lst": "^1.0.5",
3737
"chalk": "^2.3.0",
3838
"chromium-pickle-js": "^0.2.0",
@@ -95,7 +95,7 @@
9595
"gitbook-plugin-github": "^2.0.0",
9696
"gitbook-plugin-github-buttons": "^3.0.0",
9797
"globby": "^8.0.1",
98-
"jest-cli": "^22.3.0",
98+
"jest-cli": "^22.4.0",
9999
"jest-junit": "^3.6.0",
100100
"jsdoc-to-markdown": "^4.0.1",
101101
"path-sort": "^0.1.0",

packages/builder-util/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"out"
1212
],
1313
"dependencies": {
14-
"app-builder-bin": "1.3.5",
14+
"app-builder-bin": "1.3.6",
1515
"temp-file": "^3.1.1",
1616
"fs-extra-p": "^4.5.2",
1717
"is-ci": "^1.1.0",

packages/electron-builder-lib/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"homepage": "https://github.com/electron-userland/electron-builder",
4343
"dependencies": {
4444
"7zip-bin": "~3.1.0",
45-
"app-builder-bin": "1.3.5",
45+
"app-builder-bin": "1.3.6",
4646
"async-exit-hook": "^2.0.1",
4747
"bluebird-lst": "^1.0.5",
4848
"chromium-pickle-js": "^0.2.0",

packages/electron-builder-lib/src/targets/snap.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ export default class SnapTarget extends Target {
4949
description: this.helper.getDescription(options),
5050
confinement: options.confinement || "strict",
5151
grade: options.grade || "stable",
52+
architectures: [toLinuxArchString(arch)],
5253
apps: {
5354
[snapName]: {
5455
command: `bin/desktop-launch $SNAP/app/${this.packager.executableName}`,

packages/electron-publisher-s3/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
],
1313
"dependencies": {
1414
"fs-extra-p": "^4.5.2",
15-
"aws-sdk": "^2.197.0",
15+
"aws-sdk": "^2.198.0",
1616
"mime": "^2.2.0",
1717
"electron-publish": "~0.0.0-semantic-release",
1818
"builder-util": "^0.0.0-semantic-release",

test/out/linux/__snapshots__/snapTest.js.snap

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ Object {
2525
],
2626
},
2727
},
28+
"architectures": Array [
29+
"amd64",
30+
],
2831
"confinement": "strict",
2932
"description": "Test Application (test quite “ #378)",
3033
"grade": "stable",
@@ -91,6 +94,9 @@ Object {
9194
],
9295
},
9396
},
97+
"architectures": Array [
98+
"amd64",
99+
],
94100
"confinement": "strict",
95101
"description": "Test Application (test quite “ #378)",
96102
"grade": "stable",
@@ -131,6 +137,9 @@ Object {
131137
],
132138
},
133139
},
140+
"architectures": Array [
141+
"amd64",
142+
],
134143
"confinement": "classic",
135144
"description": "Test Application (test quite “ #378)",
136145
"grade": "stable",
@@ -192,6 +201,9 @@ Object {
192201
],
193202
},
194203
},
204+
"architectures": Array [
205+
"amd64",
206+
],
195207
"confinement": "classic",
196208
"description": "Test Application (test quite “ #378)",
197209
"grade": "stable",
@@ -254,6 +266,9 @@ Object {
254266
],
255267
},
256268
},
269+
"architectures": Array [
270+
"amd64",
271+
],
257272
"confinement": "classic",
258273
"description": "Test Application (test quite “ #378)",
259274
"grade": "stable",
@@ -317,6 +332,9 @@ Object {
317332
],
318333
},
319334
},
335+
"architectures": Array [
336+
"amd64",
337+
],
320338
"confinement": "classic",
321339
"description": "Test Application (test quite “ #378)",
322340
"grade": "stable",
@@ -371,6 +389,9 @@ Object {
371389
],
372390
},
373391
},
392+
"architectures": Array [
393+
"amd64",
394+
],
374395
"confinement": "strict",
375396
"description": "Test Application (test quite “ #378)",
376397
"grade": "stable",
@@ -429,6 +450,9 @@ Object {
429450
],
430451
},
431452
},
453+
"architectures": Array [
454+
"amd64",
455+
],
432456
"confinement": "strict",
433457
"description": "Test Application (test quite “ #378)",
434458
"grade": "stable",

0 commit comments

Comments
 (0)