Skip to content

build: TS6 + oxc.rs#437

Open
erickzhao wants to merge 1 commit intomainfrom
oxc-rs
Open

build: TS6 + oxc.rs#437
erickzhao wants to merge 1 commit intomainfrom
oxc-rs

Conversation

@erickzhao
Copy link
Copy Markdown
Member

@erickzhao erickzhao commented Apr 14, 2026

This PR migrates us to oxc.rs from ESLint/Prettier. Going to do this across all Ecosystem WG-owned repos.

Migration guidelines

Formatting

  • Existing Prettier configuration ported to oxfmt to minimize diff.
  • Markdown and YAML ignored.

Linting

  • oxlint configuration intentionally kept minimal. All default plugins enabled, with import added as well.
  • TypeScript repos attempt to use typeAware mode via oxlint-tsgolint.
    • This is sometimes impossible in a straight migration due to legacy moduleResolution: node settings. This is noted whenever relevant.

Other

  • husky + lint-staged set up for pre-commit hooks.
  • package.json scripts standardized as lint and lint:fix.
  • typescript dependency upgraded to v6 for building the repos. We maintain configuration compatibility with tsgo while keeping a stable version of TypeScript.
    • Where relevant (for packages.electronjs.org repos) typedoc is upgraded to 0.28 accordingly, but this triggers some socket.dev warnings that I would like reviewers to mark as acceptable risk.

Full list of PRs

TODO:

  • electron/github-app-auth-action
  • electron/remote
  • electron/windows-installer

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedoxfmt@​0.44.0901008996100
Updatedtypescript@​5.5.4 ⏵ 6.0.2100 +110090 +19990
Addedoxlint@​1.59.0991009196100
Updatedtypedoc@​0.25.13 ⏵ 0.28.181001009894 -1100
Addedoxlint-tsgolint@​0.20.01001009796100

View full report

@socket-security
Copy link
Copy Markdown

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Block High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/typedoc@0.28.18npm/entities@4.5.0

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/entities@4.5.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block High
Obfuscated code: npm markdown-it is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: ?npm/typedoc@0.28.18npm/markdown-it@14.1.1

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/markdown-it@14.1.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@erickzhao erickzhao changed the title build: TS 6 + oxc.rs build: TS6 + oxc.rs Apr 14, 2026
@erickzhao erickzhao marked this pull request as ready for review April 15, 2026 00:38
@erickzhao erickzhao requested a review from a team as a code owner April 15, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant