build: remove npx from prepublishOnly script#180
Merged
dsanders11 merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
The npx prefix is unnecessary — yarn is available via corepack (packageManager field is set) and the release workflow runs yarn install before publishing. Using npx here causes a registry fetch of yarn@latest during npm publish, which is a supply-chain risk in the publish path.
erickzhao
approved these changes
Mar 31, 2026
dsanders11
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
npxprefix inprepublishOnlyis unnecessary and creates a supply-chain risk during publish.Why this is safe to remove:
packageManager: yarn@4.10.3is set — corepack provides yarnrelease.ymlrunsyarn install --immutablebefore publishing, so yarn is guaranteed presentbuildjust callstsc, which is a devDependencyWhy
npx yarnis bad here:yarnis not a dep, so npx falls through to fetchingyarn@latestfrom the registrynpm publish— worst possible place for an uncontrolled registry fetch