fix: replace Markdown image links and raw <img> tags with alt text#187
Open
dsanders11 wants to merge 1 commit intomainfrom
Open
fix: replace Markdown image links and raw <img> tags with alt text#187dsanders11 wants to merge 1 commit intomainfrom
dsanders11 wants to merge 1 commit intomainfrom
Conversation
| // Replace <br> elements with a newline | ||
| if (tokenToCheck.content.match(/<br\s*\/?>/)) { | ||
| joinedContent += '\n'; | ||
| } |
| } | ||
| case 'html_block': | ||
| // Replace <img> and <image> tags with [Image: <alt text>] | ||
| const imgMatch = tokenToCheck.content.match(/<(?:img|image)\b[^>]*>/i); |
Member
There was a problem hiding this comment.
Is <image really valid syntax? surely not
Regardless can we parse this as XML or something? HTML typically can't be safely parsed with regex (with the exception of inline self-closed tags like <hr />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186.
Alt text seems like the easiest solution to this issue for the moment, and it fixes a real example from our existing docs which I've included as a test case.