[Bug]: Dark mode in Devtools is not working on the latest 16.0.0 - 16.0.8 / 17.0.0

[andmm]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

16.0.0 - 16.0.5

What operating system are you using?

Windows

Operating System Version

Windows 7 x64 SP1

What arch are you using?

x64

Last Known Working Electron version

15.3.4

Expected Behavior

Devtools should have a dark mode applied when the settings is set to 'Dark Mode'.

Actual Behavior

When switching to dark mode, it displays the message that 'Devtools requires a reload' but when I click on the reload button it does nothing. Restarting the app has no effect as well and stays on the light mode.

This worked fine on the previous 15.3.2 version.

Testcase Gist URL

No response

Additional Information

One thing I noticed, when updating from the last version (15.3.2) the dev tools will show up with dark mode enabled on the first run but on subsequent runs, it reverts back to light mode.

[ckerr]

Looks like this broke sometime between 16.0.0-beta.3 and 16.0.0-beta.4.

How I tested:

• select version 16.0.0-beta.3 or 16.0.0-beta.4 in electron-fiddle with a standard unchanged fiddle
• ctrl-shift-i to open devtools
• click on gear to change settings
• in settings sidebar, click 'preferences'
• under 'Appearance' setting, change 'Theme' to a new value that is not 'system preference', e.g. if current value is 'dark' or 'system preference', choose 'light'
• ctrl-shift-i to close devtools
• ctrl-shift-r to force reload
• ctrl-shift-i to reopen devtools
• clck gear to change settings again
• in settings sidebar, click 'preferences' again

Expected: 'Theme' has the same value as set in previous steps.

Actual (16.0.0-beta.3): same as expected

Acutal (16.0.9-beta.4): 'Theme' is now 'System preference' rather than the value set above

[ckerr]

v16.0.0-beta.3...v16.0.0-beta.4

[andmm]

Don't know if this is related but on clicking 'reload dev tools' I'm getting this error message sometimes, not always.

Browser window was created with barebone options (width, height, preloadScript).

[codebytere]

22df8ea feels like the most likely culprit i'd say

[andmm]

Still present in the latest 16.0.3 but not on the new 15.3.3.

[xbb]

Not only the theme but also other settings like "Preserve log" or "Log XMLHttpRequests", they work but the state don't persist