BrowserWindow.setBounds() typeError

[brianfajardo]

• Electron version: 1.6.8
• Operating system: Windows 10

Expected behavior

When passing in a configuration object {x, y, height, width} to setBounds() I expected BrowserWindow to conform to the given number type dimensions.

Actual behavior

Temporary Fix

When I logged my boundsConfig , terminal displayed:

{ x: 1621.5, y: 611, height: 501, width: 301 }

Every value is a number, however, the value of x was a floating point. I tried Math.round(x) , Math.floor(x) , Math.ceil(x) and that seemed to solve the problem. I also tried adding a literal value of 0.5 to the other variables and the same error was reproduced. Appears that setBounds() does not take floating points.

[MarshallOfSound]

@brianfajardo This would just be a docs fix on the Rectangle object. x, y, width and height all have to be integers AFAIK 👍

[brianfajardo]

Good call, I agree 👍

[TravisEEng]

Hello,

Would it be possible if I were to attempt to fix this (first time contributor).

From my understanding, I just have to go do to the document

docs/api/structures/rectangle.md

and specify that the following parameters have to all be integers, and include the comment "ci skip" when committing.

Please let me know if I can help with this, or if I have made a mistake and someone is already on it!

Thanks

[kevinsawicki]

Fixed by #9721

[Vegvizer]

Hi guys,
the issue is that the setBounds() can't get a float number, in order to fix it you can use the Math round function:

for example
const yPosition = process.platform === 'darwin' ? y : y - height;
const xPosition = Math.round(x - width/2);
BrowerWindow.setBounds({
x: xPosition ,
y: yPosition,
width,
height,
});