New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to access logs in getPath() #10191

Merged
merged 17 commits into from Sep 29, 2017

Conversation

Projects
None yet
6 participants
@codebytere
Member

codebytere commented Aug 3, 2017

Adds the ability to get logs via app.getPath('logs'), implementing feature requested in #10118.

  • MacOS
  • Linux
  • Windows

Nota Bene: Unlike MacOS, Linux & Windows do not create log folders until a log-worthy event happens, so this implementation lets the app developer ensure the directory exists. If anyone has an idea for an alternate way this could be dealt with please let me know!

@jkleinsc jkleinsc changed the title from add ability to access logs in getPath() to [WIP] add ability to access logs in getPath() Aug 7, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Aug 10, 2017

Member

Hey @codebytere do you wanna take a shot at adding some docs for this too?

Member

zeke commented Aug 10, 2017

Hey @codebytere do you wanna take a shot at adding some docs for this too?

@zeke zeke self-assigned this Aug 16, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Sep 20, 2017

Member

Sorry for not getting to this earlier, @codebytere. Would you mind rebasing with master and pushing the changes up to see if we can get CI passing?

Member

zeke commented Sep 20, 2017

Sorry for not getting to this earlier, @codebytere. Would you mind rebasing with master and pushing the changes up to see if we can get CI passing?

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Sep 24, 2017

Member

@codebytere I rebased with master (again) and am seeing this error on CircleCI:

../../brightray/browser/browser_main_parts.cc:110:29: error: unexpected ':' in nested name specifier; did you mean '::'?
  std::string homePath = std:string(getenv("HOME"));
Member

zeke commented Sep 24, 2017

@codebytere I rebased with master (again) and am seeing this error on CircleCI:

../../brightray/browser/browser_main_parts.cc:110:29: error: unexpected ':' in nested name specifier; did you mean '::'?
  std::string homePath = std:string(getenv("HOME"));

@zeke zeke requested a review from zcbenz Sep 28, 2017

@zeke

This comment has been minimized.

Show comment
Hide comment
@zeke

zeke Sep 28, 2017

Member

@zcbenz does this look good to you?

Member

zeke commented Sep 28, 2017

@zcbenz does this look good to you?

Shelley Vohr and others added some commits Aug 3, 2017

@codebytere codebytere requested review from electron/docs as code owners Sep 28, 2017

@codebytere codebytere changed the title from [WIP] add ability to access logs in getPath() to add ability to access logs in getPath() Sep 29, 2017

codebytere added some commits Sep 29, 2017

All requested changes were made.

@zeke

zeke approved these changes Sep 29, 2017

@zeke zeke merged commit 9f89587 into master Sep 29, 2017

8 checks passed

ci/circleci: electron-linux-arm Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-arm64 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-ia32 Your tests passed on CircleCI!
Details
ci/circleci: electron-linux-x64 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
electron-mas-x64 Build #5277 succeeded in 24 min
Details
electron-osx-x64 Build #5261 succeeded in 25 min
Details

@zeke zeke deleted the add_log_path_support branch Sep 29, 2017

void BrowserMainParts::OverrideAppLogsPath() {
base::FilePath path;
NSString* bundleName = [[[NSBundle mainBundle] infoDictionary]
objectForKey:@"CFBundleName"];

This comment has been minimized.

@pronebird

pronebird Sep 30, 2017

(id)kCFBundleNameKey

@pronebird

pronebird Sep 30, 2017

(id)kCFBundleNameKey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment