fix: Windows: Calling window.setFocusable(true) will no longer cause a window to lose focus#45640
Merged
jkleinsc merged 1 commit intoelectron:mainfrom Nov 12, 2025
Merged
Conversation
ckerr
approved these changes
Oct 31, 2025
Member
ckerr
left a comment
ckerr
left a comment
There was a problem hiding this comment.
This looks reasonable to me.
CC @codebytere for a second opinion since she self-requested a review on this PR
…not deactivate a window when setting focusable to true.
jkleinsc
force-pushed
the
vulture/fix-setfocusable
branch
from
21ae330 to
e39b648
Compare
jkleinsc
changed the title
codebytere
approved these changes
Nov 12, 2025
codebytere
added
semver/patch
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #48927 |
trop
bot
added
in-flight/40-x-y
and removed
target/40-x-y
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #48928 |
trop
bot
added
in-flight/39-x-y
merged/39-x-y
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…a window to lose focus (electron#45640) Make setFocusable only deactivate a window if focusable is false. Do not deactivate a window when setting focusable to true.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…a window to lose focus (electron#45640) Make setFocusable only deactivate a window if focusable is false. Do not deactivate a window when setting focusable to true.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…a window to lose focus (electron#45640) Make setFocusable only deactivate a window if focusable is false. Do not deactivate a window when setting focusable to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
On Windows, calling
NativeWindowViews::SetFocusable(bool focusable)currently always callsFocus(false)at the end of the function regardless of if we're setting focusable to true or false. While it does make sense to lose focus when callingSetFocusable(false), it doesn't make sense to drop focus when callingSetFocusable(true). Setting totrueshould also not forcibly focus. So I propose to drop focus only when!focusable, and do not callFocus()at all whenfocusable.Release Notes
Notes: Windows: Calling window.setFocusable(true) will no longer cause a window to lose focus