Skip to content

fix: ElectronBrowserContext raw_ptr bug + remove dead code#46030

Merged
ckerr merged 1 commit intomainfrom
refactor/remove-unused-ElectronBrowserContext.extension_system
Mar 15, 2025
Merged

fix: ElectronBrowserContext raw_ptr bug + remove dead code#46030
ckerr merged 1 commit intomainfrom
refactor/remove-unused-ElectronBrowserContext.extension_system

Conversation

@ckerr
Copy link
Copy Markdown
Member

@ckerr ckerr commented Mar 13, 2025 •
edited
Loading

Description of Change

  • Remove ElectronBrowserContext::extension_system(), whose last caller was removed on Jul 21, 2020 by 94e64af in PR chore: bump chromium to 1a093e6a0cb5e72ba78990fe39824 (master) #24575...
  • ...which, in turn, lets us remove the raw_ptr field ElectronBrowserContext::extension_system_ ...
  • ...which, in turn, fixes the thing that got me looking at this part of the code: a raw_ptr error in the ElectronBrowserContext destructor 🙌

Checklist

Release Notes

Notes: none.

@ckerr
refactor: remove unused ElectronBrowserContext::extension_system()
6a31386 
Last use removed on Jul 21, 2020 by 2fb14f5 in PR #24575

This fixes a raw_ptr warning by letting us remove the raw_ptr field
`ElectronBrowserContext::extension_system_`.
@ckerr ckerr added semver/patch backwards-compatible bug fixes target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Mar 13, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 13, 2025
@ckerr ckerr changed the title fix: remove unused ElectronBrowserContext::extension_system() fix: ElectronBrowserContext raw_ptr bug + remove dead code Mar 14, 2025
@ckerr ckerr changed the title fix: ElectronBrowserContext raw_ptr bug + remove dead code fix: ElectronBrowserContext raw_ptr bug + remove dead code Mar 14, 2025
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 14, 2025
@ckerr ckerr merged commit 5f0603e into main Mar 15, 2025
74 checks passed
@ckerr ckerr deleted the refactor/remove-unused-ElectronBrowserContext.extension_system branch March 15, 2025 04:35
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Mar 15, 2025

No Release Notes

This was referenced Mar 15, 2025
Merged
Merged
Merged
Merged
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 15, 2025

I have automatically backported this PR to "35-x-y", please check out #46053

@trop trop bot added in-flight/35-x-y and removed target/35-x-y PR should also be added to the "35-x-y" branch. labels Mar 15, 2025
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 15, 2025

I have automatically backported this PR to "34-x-y", please check out #46054

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 15, 2025

I have automatically backported this PR to "33-x-y", please check out #46055

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Mar 15, 2025

I have automatically backported this PR to "36-x-y", please check out #46056

@trop trop bot added in-flight/34-x-y in-flight/33-x-y in-flight/36-x-y and removed target/34-x-y PR should also be added to the "34-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. labels Mar 15, 2025
@trop trop bot added merged/33-x-y PR was merged to the "33-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. and removed in-flight/33-x-y in-flight/36-x-y in-flight/34-x-y in-flight/35-x-y labels Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

Assignees

No one assigned

Labels

merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. merged/35-x-y PR was merged to the "35-x-y" branch. merged/36-x-y PR was merged to the "36-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ckerr @codebytere