Skip to content

feat: add sharedTexture module to import shared texture#47317

Merged
codebytere merged 1 commit intoelectron:mainfrom
reitowo:main-import-texture-min
Nov 7, 2025
Merged

feat: add sharedTexture module to import shared texture#47317
codebytere merged 1 commit intoelectron:mainfrom
reitowo:main-import-texture-min

Conversation

@reitowo
Copy link
Copy Markdown
Member

@reitowo reitowo commented May 30, 2025

Description of Change

Import shared texture. Split from #46811

Release Notes

Notes: Added support to import external shared texture as VideoFrame.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 30, 2025
@reitowo reitowo force-pushed the main-import-texture-min branch from e045627 to 789ecfc Compare May 30, 2025 19:13
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 6, 2025
@reitowo reitowo closed this Aug 8, 2025
@reitowo reitowo reopened this Aug 9, 2025
@reitowo reitowo marked this pull request as ready for review August 9, 2025 13:07
@reitowo reitowo force-pushed the main-import-texture-min branch from 789ecfc to 795a4f6 Compare August 9, 2025 13:14
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 9, 2025
@reitowo reitowo force-pushed the main-import-texture-min branch from 795a4f6 to 6714450 Compare August 9, 2025 13:20
@reitowo reitowo added api-review/requested 🗳 no-backport semver/minor backwards-compatible functionality labels Aug 9, 2025
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Aug 9, 2025

I'll update some new changes in electron/rfcs#17 and discuss at meeting, this won't merge before the rfc is passed.

@reitowo reitowo force-pushed the main-import-texture-min branch 5 times, most recently from b7691ad to f15d2b8 Compare August 13, 2025 14:05
@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Aug 13, 2025

The managed API's performance looks good to me!

image

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 16, 2025
@reitowo reitowo force-pushed the main-import-texture-min branch from fb6331c to ccec485 Compare August 25, 2025 16:01
@reitowo reitowo added the target/39-x-y PR should also be added to the "39-x-y" branch. label Sep 8, 2025
@reitowo reitowo force-pushed the main-import-texture-min branch from 31a251f to 6f65b01 Compare October 15, 2025 13:46
@reitowo reitowo force-pushed the main-import-texture-min branch 3 times, most recently from f056461 to b76c730 Compare October 17, 2025 12:16
@david-metrica
Copy link
Copy Markdown
Contributor

Hi! Is there an ETA for when this might be merged, or anything still pending before it can be?
We’d love to try this out, and it would be great to avoid having to maintain a fork if possible.
Thanks for all the work on this!
@reitowo @jkleinsc @samuelmaddock

@reitowo
Copy link
Copy Markdown
Member Author

reitowo commented Nov 4, 2025

Hi, if there's no other changes needed, the optimistic situation would be no later than this Thursday.

@reitowo reitowo force-pushed the main-import-texture-min branch 2 times, most recently from ab2ff70 to 5261e29 Compare November 5, 2025 10:22
@reitowo reitowo force-pushed the main-import-texture-min branch from 5261e29 to 8f035b5 Compare November 5, 2025 13:26
Copy link
Copy Markdown
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

Copy link
Copy Markdown
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@codebytere codebytere merged commit bab11f8 into electron:main Nov 7, 2025
102 of 104 checks passed
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Nov 7, 2025

Release Notes Persisted

Added support to import external shared texture as VideoFrame.

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Nov 7, 2025

I have automatically backported this PR to "40-x-y", please check out #48831

@trop trop bot added in-flight/40-x-y and removed target/40-x-y PR should also be added to the "40-x-y" branch. labels Nov 7, 2025
@trop
Copy link
Copy Markdown
Contributor

trop bot commented Nov 7, 2025

I have automatically backported this PR to "39-x-y", please check out #48832

@trop trop bot added in-flight/39-x-y merged/40-x-y PR was merged to the "40-x-y" branch. and removed target/39-x-y PR should also be added to the "39-x-y" branch. in-flight/39-x-y in-flight/40-x-y labels Nov 7, 2025
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review/approved ✅ merged/40-x-y PR was merged to the "40-x-y" branch. semver/minor backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants