Fix: Improve Per-Monitor DPI Scaling on Windows to Address Blurriness#47322
Fix: Improve Per-Monitor DPI Scaling on Windows to Address Blurriness#47322utahisnotastate wants to merge 2 commits intoelectron:mainfrom
Conversation
…iews.
This commit introduces C++ unit tests for the recently added Windows-specific
DPI change handling logic in `NativeWindowViews`. These tests aim to ensure
the correct processing of `WM_DPICHANGED` messages and the subsequent
internal state updates and view refreshes.
Changes include:
1. **New Test File:**
- Created `shell/browser/native_window_views_win_unittest.cc` to house
the new unit tests.
2. **New Test Target:**
- Added a new test target `electron_browser_unittests_win` to the root
`BUILD.gn` file. This target compiles the new unit tests for Windows builds.
3. **Tests for `NativeWindowViews::PreHandleMSG`:**
- Verified that when `WM_DPICHANGED` is processed:
- `NativeWindowViews::OnHostDpiChanged` is invoked with the correct new DPI.
- The message is correctly marked as handled (return value and result code).
- Other messages are ignored by this specific handler.
4. **Tests for `NativeWindowViews::OnHostDpiChanged`:**
- Verified that:
- The internal `current_dpi_` member of `NativeWindowViews` is updated.
- The `needs_layout` flag is set on the widget's root view and
non-client frame view, indicating they are prepared for re-layout.
5. **Code Modification for Testability:**
- Changed the `current_dpi_` member in `NativeWindowViews` from `private`
to `protected` to allow the derived test class to access it for
verification.
- Added a public getter `GetCurrentDpi()` to the `TestNativeWindowViews`
mock/test class.
These tests provide coverage for the core logic responsible for making Electron
windows adapt to DPI changes triggered by `WM_DPICHANGED`, contributing to
the fix for blurriness issues on Windows 11.
|
💖 Thanks for opening this pull request! 💖 Semantic PR titlesWe use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Commit signingThis repo enforces commit signatures for all incoming PRs. PR tipsThings that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
utahisnotastate
changed the title
|
Will these changes also fix #10862 or/and #47322 ? |
| bool NativeWindowViews::PreHandleMSG(UINT message, | ||
| WPARAM w_param, | ||
| LPARAM l_param, | ||
| LRESULT* result) { | ||
| if (message == WM_DPICHANGED) { | ||
| WORD new_dpi_y = LOWORD(w_param); | ||
| RECT* const prcNewWindow = reinterpret_cast<RECT*>(l_param); | ||
|
|
||
| ::SetWindowPos(GetAcceleratedWidget(), | ||
| nullptr, | ||
| prcNewWindow->left, | ||
| prcNewWindow->top, | ||
| prcNewWindow->right - prcNewWindow->left, | ||
| prcNewWindow->bottom - prcNewWindow->top, | ||
| SWP_NOZORDER | SWP_NOACTIVATE); | ||
|
|
||
| OnHostDpiChanged(new_dpi_y); | ||
| *result = 0; | ||
| return true; | ||
| } | ||
| // TODO(bridiver) handle other messages here | ||
| return false; | ||
| } | ||
|
|
||
| void NativeWindowViews::OnHostDpiChanged(int new_dpi) { | ||
| current_dpi_ = new_dpi; | ||
|
|
||
| if (widget()) { | ||
| widget()->UpdateWindowIcon(); | ||
|
|
||
| if (widget()->non_client_view() && widget()->non_client_view()->frame_view()) { | ||
| widget()->non_client_view()->frame_view()->InvalidateLayout(); | ||
| widget()->non_client_view()->frame_view()->SchedulePaint(); | ||
| } | ||
|
|
||
| widget()->GetRootView()->Layout(); | ||
| widget()->GetRootView()->SchedulePaint(); | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems to duplicate what the default handing is performed in the runtime today via https://source.chromium.org/chromium/chromium/src/+/main:ui/views/win/hwnd_message_handler.cc;l=1876-1921 , can you clarify why this is needed ?
|
The quality of this PR doesn't meet our standards for a few reasons, including:
Based on these oddities and Jules clearly identifiable in the commit, we suspect this PR of being entirely AI-generated. While Electron appreciates and encourages community contributions, its maintainers only have limited bandwidth. AI-generated PRs will not be reviewed and will be closed as invalid. This PR will now be closed. In the future, raising more PRs with purely AI generated content will result in a organization level ban. |
4 participants
Problem:
Electron applications on Windows 11 can exhibit blurriness when moved between monitors with different DPI scaling factors or when window focus changes. This is attributed to Windows 11's aggressive DPI management for unfocused windows and Electron not fully implementing Per-Monitor DPI Awareness version 2 (PMv2), leading to improper bitmap scaling.
Solution:
This Pull Request implements robust Per-Monitor DPI V2 awareness and handling for Electron on Windows by:
Updating Application Manifest:
shell/browser/resources/win/dpi_aware.manifesthas been updated to declare<dpiAwareness>PerMonitorV2, System</dpiAwareness>, with a fallback to<dpiAware>true/pm</dpiAware>. This explicitly enables Per-Monitor DPI Awareness v2, which is the recommended setting for modern Windows applications to correctly handle dynamic DPI changes.Implementing
WM_DPICHANGEDHandler:WM_DPICHANGEDWindows message has been added toNativeWindowViews::PreHandleMSG.SetWindowPosbased on the pixel rectangle suggested by Windows in the message'slParam. This ensures the window's physical size correctly adapts to the new DPI.NativeWindowViews::OnHostDpiChanged(int new_dpi), is invoked to propagate the DPI change within Electron's view system.OnHostDpiChangedmethod updates internal DPI tracking and forces a re-layout and repaint of the window's non-client frame view and root view, ensuring custom UI elements refresh correctly at the new DPI.Leveraging Existing DPI-Aware Views Logic:
WinFrameView(for custom window frames) and other view components already utilize DPI-aware system calls (e.g.,GetSystemMetricsInDIP,GetDPIScale) for their layout and painting. The newWM_DPICHANGEDhandling and subsequent layout invalidations are designed to trigger these existing mechanisms, allowing them to use the updated DPI information from the OS.Testing:
shell/browser/native_window_views_win_unittest.cc.WM_DPICHANGEDwithinNativeWindowViews::PreHandleMSGto the newOnHostDpiChangedmethod.NativeWindowViews.electron_browser_unittests_win, has been added to the rootBUILD.gnto compile and run these tests on Windows.Impact:
These changes should significantly improve the visual experience for Electron app users on Windows 11 multi-monitor setups with varying DPIs, reducing or eliminating the reported blurriness.