build: write abi version to published npm package#47598
Merged
MarshallOfSound merged 1 commit intomainfrom Jun 30, 2025
Merged
Conversation
codebytere
approved these changes
Jun 30, 2025
Member
|
@MarshallOfSound do we want to backport this? |
Member
Author
|
Want to be sure it works first 🤣 will wait for a good nightly and then BP |
|
Release Notes Persisted
|
codebytere
pushed a commit
that referenced
this pull request
Jul 11, 2025
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a helper file that makes it easier for tools like
node-abito determine the ABI version of an otherwise unknown package.node-abiis a pretty massive source of annoyance for folks, even for seasoned Electron App developers it's an annoying thing you need to keep ensuring you update. Package managers don't make it easy, so instead to mitigate this as much as possible I'm proposing we write this file to disk, and then innode-abiif we are resolving a version we don't recognize we try to find this file on disk for a matching electron version. If it matches, and it exists, we can serve it and app developers don't need to do any package manager shenanigans.Notes: Added
abi_versionfile to the npm package