fix: offscreen mode under window.open creation#47868
Merged
codebytere merged 1 commit intomainfrom Aug 5, 2025
Merged
Conversation
codebytere
added
semver/patch
codebytere
changed the title
window.open creation
codebytere
force-pushed
the
offscreen-new-window
branch
from
e73b2c0 to
168714d
Compare
jkleinsc
approved these changes
Jul 31, 2025
codebytere
force-pushed
the
offscreen-new-window
branch
from
168714d to
d9d06f9
Compare
codebytere
force-pushed
the
offscreen-new-window
branch
from
29baff7 to
c788202
Compare
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "37-x-y" cleanly; |
trop
bot
removed
the
target/37-x-y
Contributor
|
I was unable to backport this PR to "36-x-y" cleanly; |
trop
bot
added
needs-manual-bp/37-x-y
and removed
target/36-x-y
Contributor
|
I was unable to backport this PR to "38-x-y" cleanly; |
trop
bot
added
needs-manual-bp/36-x-y
needs-manual-bp/38-x-y
and removed
target/38-x-y
3 tasks
clavin
pushed a commit
that referenced
this pull request
Aug 10, 2025
fix: offscreen mode under new window creation
Contributor
codebytere
added a commit
that referenced
this pull request
Aug 10, 2025
fix: offscreen mode under `window.open` creation (#47868) fix: offscreen mode under new window creation Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop
bot
added
merged/38-x-y
Contributor
|
@codebytere has manually backported this PR to "37-x-y", please check out #48070 |
Contributor
|
@codebytere has manually backported this PR to "36-x-y", please check out #48074 |
trop
bot
added
in-flight/36-x-y
merged/37-x-y
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: offscreen mode under new window creation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #34095
Fixes an issue where windows opened with
window.openwould never be offscreen regardless of what the user overrode viasetWindowOpenHandler. This adjusts an existing patch to allow overriding thedelegate_viewandviewinCreateParamsthe same way we do for an offscreen window opened via the typicalBrowserWindowconstructor.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where windows opened with
window.openwould never be offscreen.