fix: dark mode on Linux default themeing#47869
Merged
codebytere merged 1 commit intomainfrom Jul 31, 2025
Merged
Conversation
codebytere
added
semver/patch
deepak1556
approved these changes
Jul 23, 2025
codebytere
force-pushed
the
fix-linux-dark-mode
branch
from
2c7a09c to
ace2a1a
Compare
|
Release Notes Persisted
|
This was referenced Jul 31, 2025
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #47919 |
trop
bot
added
in-flight/38-x-y
and removed
target/38-x-y
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #47920 |
trop
bot
added
in-flight/37-x-y
merged/37-x-y
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #47842
Refs CL:6469606
Fixes an issue where windows used dark theme on Linux all the time without reacting to system theme changes.
We need to take an approach similar to that in
BrowserDesktopWindowTreeHostLinuxand override theprefers_dark_themeproperty based on our ownui::LinuxUiGetter.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where windows used dark theme on Linux all the time without reacting to system theme changes.