fix: shell.openPath should be non-blocking#48079
Merged
VerteDinde merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
codebytere
added
target/36-x-y
deepak1556
approved these changes
Aug 14, 2025
VerteDinde
approved these changes
Aug 15, 2025
|
Release Notes Persisted
|
This was referenced Aug 15, 2025
Contributor
|
I have automatically backported this PR to "36-x-y", please check out #48087 |
Contributor
|
I have automatically backported this PR to "37-x-y", please check out #48088 |
trop
bot
removed
the
target/36-x-y
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48089 |
trop
bot
added
in-flight/37-x-y
in-flight/38-x-y
merged/36-x-y
trop
bot
added
merged/38-x-y
1 task
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
fix: shell.openPath should be non-blocking
tobias-jarvelov
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
Mar 26, 2026
As of this upstream PR[1] the underlying C implementation for shell.openPath no longer waits for the process to exit, which means that the callback in the C code will never be called. That callback is what eventually causes the promise returned by shell.openPath to resolve, and as it is never being called, the promise will never be resolved. Because of that, we just invoke shell.openPath and return a promise resolved with an empty string, the same signature as returned from shell.openPath. [1] electron/electron#48079
tobias-jarvelov
added a commit
to mullvad/mullvadvpn-app
that referenced
this pull request
Apr 2, 2026
As of this upstream PR[1] the underlying C implementation for shell.openPath no longer waits for the process to exit, which means that the callback in the C code will never be called. That callback is what eventually causes the promise returned by shell.openPath to resolve, and as it is never being called, the promise will never be resolved. Because of that, we just invoke shell.openPath and return a promise resolved with an empty string, the same signature as returned from shell.openPath. [1] electron/electron#48079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #47668.
Fixes an issue where
shell.openPathwas not non-blocking as expected.Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where
shell.openPathwas not non-blocking as expected.