Conversation
dsanders11
approved these changes
Oct 3, 2025
VerteDinde
approved these changes
Oct 6, 2025
codebytere
added
the
target/39-x-y
codebytere
approved these changes
Oct 7, 2025
codebytere
force-pushed
the
build/bump-nvmrc
branch
from
ddfb6c6 to
6f7ade8
Compare
jkleinsc
approved these changes
Oct 8, 2025
Member
|
Merging as CI failure unrelated to PR change. |
|
No Release Notes |
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #48491 |
trop
bot
added
in-flight/39-x-y
merged/39-x-y
TheCommieAxolotl
pushed a commit
to TheCommieAxolotl/electron
that referenced
this pull request
Nov 2, 2025
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
build-tools requires Node v22. This updates our .nvmrc file to reflect that.
https://github.com/electron/build-tools/blob/c13f4bdb50e65da46a4703f8f882079dd21fd99e/src/utils/prereqs.js#L6
Checklist
Release Notes
Notes: none