fix: CSD window frame tiles properly on Wayland#48765
fix: CSD window frame tiles properly on Wayland#48765codebytere merged 1 commit intoelectron:mainfrom
Conversation
There was a problem hiding this comment.
@mitchchn i pulled the branch down and ran it - and I still see this:
I'm running Wayland on Ubuntu 24.04, using the default Fiddle. Is there anything I'm missing?
|
@codebytere this PR is for window tiling which isn't in your screenshot. When you tile left/right, you should now see:
(If you are talking about the window titlebar buttons being on the wrong side, that was fixed in a different PR, but you can't yet tell in Fiddle because its version of Electron still sets the old environment variable which propagates to child processes.) |
f80520f to
543020a
Compare
543020a to
d82d23b
Compare
|
Release Notes Persisted
|
|
I have automatically backported this PR to "39-x-y", please check out #48834 |
|
I have automatically backported this PR to "40-x-y", please check out #48835 |
|
I have automatically backported this PR to "38-x-y", please check out #48836 |
fix: CSD window frame tiles properly on Linux
fix: CSD window frame tiles properly on Linux
fix: CSD window frame tiles properly on Linux
Description of Change
On Wayland compositors that use CSD (GNOME), tiled windows had a non-tiled appearance with rounded corners and shadows on all sides, and they showed resize handles on all edges.
Reasons for the issue:
Some issues with tiling and resize handles were addressed previously in #46155. This PR fully restores the correct tiled appearance and behaviours without regressing those fixes.
Relates to #45916. This PR fixes tiling resize handles for CSD windows, but not (yet) for fully frameless windows (frame: false/WCO) because this technique requires a GTK client frame. This solution will however also apply to frameless windows when they get a client frame + shadows.
Before:
After:
Checklist
npm testpassesRelease Notes
Notes: Corrected the appearance of tiled windows on GNOME (when frame: true), and removed resize handles from tiled edges.