fix: enable wasm trap handlers in all Node.js processes#48788
Merged
deepak1556 merged 2 commits intomainfrom Nov 7, 2025
Merged
fix: enable wasm trap handlers in all Node.js processes#48788deepak1556 merged 2 commits intomainfrom
deepak1556 merged 2 commits intomainfrom
Conversation
codebytere
approved these changes
Nov 5, 2025
e6e6567 to
4032771
Compare
4032771 to
f7ea5f4
Compare
Member
Author
|
New commit pushes the registration to respective process since we need to wait for feature list initialization. |
codebytere
approved these changes
Nov 7, 2025
|
Release Notes Persisted
|
Contributor
|
I was unable to backport this PR to "37-x-y" cleanly; |
This was referenced Nov 7, 2025
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #48837 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #48838 |
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #48839 |
|
crashed caused by this pr. |
3 tasks
Member
Author
|
@beyondkmp please share the minidump file from crashpad or if you have a repro that would be better too. |
VerteDinde
added a commit
that referenced
this pull request
Nov 14, 2025
…)" This reverts commit ca0b46b.
5 tasks
trop bot
added a commit
that referenced
this pull request
Nov 14, 2025
…)" This reverts commit ca0b46b. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
trop bot
added a commit
that referenced
this pull request
Nov 14, 2025
…)" This reverts commit ca0b46b. Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* fix: enable wasm trap handlers in all Node.js processes * fix: separate registrations to account for featurelist init
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…ctron#48973) Revert "fix: enable wasm trap handlers in all Node.js processes (electron#48788)" This reverts commit ca0b46b.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* fix: enable wasm trap handlers in all Node.js processes * fix: separate registrations to account for featurelist init
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…ctron#48973) Revert "fix: enable wasm trap handlers in all Node.js processes (electron#48788)" This reverts commit ca0b46b.
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
* fix: enable wasm trap handlers in all Node.js processes * fix: separate registrations to account for featurelist init
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
…ctron#48973) Revert "fix: enable wasm trap handlers in all Node.js processes (electron#48788)" This reverts commit ca0b46b.
This was referenced Nov 24, 2025
This was referenced Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Found while investigating microsoft/vscode#273191
Since #47186 we had accidentally disabled V8 trap handlers in browser and utility process. This incurs performance cost when executing wasm due to inlined bound checks.
Enable the feature back and align it with upstream based on the feature parameter across all processes features::kWebAssemblyTrapHandler
Current matrix of enabled platforms.
Release Notes
Notes: Reenable V8 trap handlers for wasm in browser and utility process, improves runtime execution of wasm