Conversation
trop
bot
added
39-x-y
backport
Member
Looks like the usual patch shear. I'll push up a fix. |
Co-authored-by: deepak1556 <hop2deep@gmail.com>
chore: fix trop patch shear
ckerr
force-pushed
the
trop/39-x-y-bp-fix-exception-when-reading-system-certificates-via-nodejs-1763739313099
branch
from
b482790 to
dd24f20
Compare
ckerr
previously approved these changes
Nov 24, 2025
ckerr
dismissed
their stale review
Oh, I didn't notice this was a draft before I hit approve.
The idea still LGTM, just not approving b/c it's still a draft :)
Member
|
Not sure what I was smoking; this isn't a draft. I think I may have intended that comment for a different browser window 😵 |
ckerr
approved these changes
Nov 24, 2025
ckerr
deleted the
trop/39-x-y-bp-fix-exception-when-reading-system-certificates-via-nodejs-1763739313099
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49028
See that PR for details.
Notes: fix crash when reading system certificates via nodejs tls module