fix: only call popup closecallback for top-level menu#49047
Merged
codebytere merged 1 commit into38-x-yfrom Nov 23, 2025
Merged
Conversation
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
3 tasks
trop
bot
added
38-x-y
backport
codebytere
approved these changes
Nov 23, 2025
codebytere
deleted the
trop/38-x-y-bp-fix-only-call-popup-closecallback-for-top-level-menu-1763739475895
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49017
See that PR for details.
Notes: Fixed an issue where the close callback param for
menu.popupwould fire when any arbitrary submenu of the given menu closed, and not the menu itself.