fix: ensure menu-did-close is emitted for application menus

[codebytere]

Description of Change

Follow up to #49017

Correct logic for event emission: we should emit "menu-did-close" both if it's a popup and the top level menu is closed, or if it's an application menu, and the current menu's supermenu
is the top-level menu.

Checklist

• PR description included and stakeholders cc'd
• npm test passes(https://github.com/electron/electron/blob/main/docs/development/style-guide.md)
• PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed an issue where menu-did-close was not emitted properly for some application menus.

[ckerr]

FTBFS

2025-11-25T17:54:49.6225600Z ##[error]../../electron/shell/browser/ui/cocoa/electron_menu_controller.mm:190:3: error: use of undeclared identifier 'popupCloseCallback'; did you mean 'closeCallback'?
2025-11-25T17:54:49.6228830Z   190 |   popupCloseCallback = std::move(callback);
2025-11-25T17:54:49.6229230Z       |   ^~~~~~~~~~~~~~~~~~
2025-11-25T17:54:49.6229530Z       |   closeCallback
2025-11-25T17:54:49.6230250Z ../../electron/shell/browser/ui/cocoa/electron_menu_controller.h:31:21: note: 'closeCallback' declared here
2025-11-25T17:54:49.6232190Z    31 |   base::OnceClosure closeCallback;
2025-11-25T17:54:49.6232700Z       |                     ^
2025-11-25T17:54:49.6234930Z ##[error]../../electron/shell/browser/ui/cocoa/electron_menu_controller.mm:224:10: error: use of undeclared identifier 'popupCloseCallback'; did you mean 'closeCallback'?
2025-11-25T17:54:49.6235700Z   224 |     if (!popupCloseCallback.is_null()) {
2025-11-25T17:54:49.6236050Z       |          ^~~~~~~~~~~~~~~~~~
2025-11-25T17:54:49.6236410Z       |          closeCallback
2025-11-25T17:54:49.6237150Z ../../electron/shell/browser/ui/cocoa/electron_menu_controller.h:31:21: note: 'closeCallback' declared here
2025-11-25T17:54:49.6237840Z    31 |   base::OnceClosure closeCallback;
2025-11-25T17:54:49.6238210Z       |                     ^
2025-11-25T17:54:49.6239410Z ##[error]../../electron/shell/browser/ui/cocoa/electron_menu_controller.mm:226:32: error: use of undeclared identifier 'popupCloseCallback'; did you mean 'closeCallback'?
2025-11-25T17:54:49.6240210Z   226 |           FROM_HERE, std::move(popupCloseCallback));
2025-11-25T17:54:49.6240710Z       |                                ^~~~~~~~~~~~~~~~~~
2025-11-25T17:54:49.6241100Z       |                                closeCallback
2025-11-25T17:54:49.6241920Z ../../electron/shell/browser/ui/cocoa/electron_menu_controller.h:31:21: note: 'closeCallback' declared here
2025-11-25T17:54:49.6242440Z    31 |   base::OnceClosure closeCallback;
2025-11-25T17:54:49.6242680Z       |                     ^
2025-11-25T17:54:49.6244830Z ##[error]../../electron/shell/browser/ui/cocoa/electron_menu_controller.mm:570:24: error: use of undeclared identifier 'popupCloseCallback'; did you mean 'closeCallback'?
2025-11-25T17:54:49.6245590Z   570 |   bool has_close_cb = !popupCloseCallback.is_null();
2025-11-25T17:54:49.6245950Z       |                        ^~~~~~~~~~~~~~~~~~
2025-11-25T17:54:49.6246310Z       |                        closeCallback
2025-11-25T17:54:49.6247040Z ../../electron/shell/browser/ui/cocoa/electron_menu_controller.h:31:21: note: 'closeCallback' declared here
2025-11-25T17:54:49.6247510Z    31 |   base::OnceClosure closeCallback;
2025-11-25T17:54:49.6247900Z       |                     ^
2025-11-25T17:54:49.6249050Z ##[error]../../electron/shell/browser/ui/cocoa/electron_menu_controller.mm:588:60: error: use of undeclared identifier 'popupCloseCallback'; did you mean 'closeCallback'?
2025-11-25T17:54:49.6249870Z   588 |                                                  std::move(popupCloseCallback));
2025-11-25T17:54:49.6250340Z       |                                                            ^~~~~~~~~~~~~~~~~~
2025-11-25T17:54:49.6250760Z       |                                                            closeCallback
2025-11-25T17:54:49.6251510Z ../../electron/shell/browser/ui/cocoa/electron_menu_controller.h:31:21: note: 'closeCallback' declared here
2025-11-25T17:54:49.6252070Z    31 |   base::OnceClosure closeCallback;

[ckerr]

new commits; reapproving

[release-clerk]

Release Notes Persisted

Fixed an issue where menu-did-close was not emitted properly for some application menus.

[trop]

I have automatically backported this PR to "40-x-y", please check out #49092

[trop]

I have automatically backported this PR to "39-x-y", please check out #49093

[trop]

I have automatically backported this PR to "38-x-y", please check out #49094