fix: reduce stack memory consumption in BytecodeGenerator#49360
Merged
deepak1556 merged 1 commit into39-x-yfrom Jan 13, 2026
Merged
fix: reduce stack memory consumption in BytecodeGenerator#49360deepak1556 merged 1 commit into39-x-yfrom
deepak1556 merged 1 commit into39-x-yfrom
Conversation
deepak1556
added
semver/patch
Backports 1) https://chromium-review.googlesource.com/c/v8/v8/+/7180480 2) https://chromium-review.googlesource.com/c/v8/v8/+/7160576 3) https://chromium-review.googlesource.com/c/v8/v8/+/7062734 2 and 3 are needed to cleanly land 1. However, most of the code changes are noop since v8_flags.proto_assign_seq_opt is experimental and disabled by default for feature. The reason why stack memory consumption is improved for all scenarios can be found in microsoft/vscode#283403 (comment)
deepak1556
force-pushed
the
robo/fix_stackoverflow_nested_functions
branch
from
e208c7a to
6706b23
Compare
codebytere
approved these changes
Jan 13, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
For microsoft/vscode#283403
Backports
2 and 3 are needed to cleanly land 1. However, most of the code changes are noop since
v8_flags.proto_assign_seq_optis experimental in this branch and disabled by default. The reason why stack memory consumption is improved for all scenarios can be found in microsoft/vscode#283403 (comment)NB: Changes are present in M144 and higher
Release Notes
Notes: fix stack overflow when compiling deeply nested JS functions