fix: revert os_crypt async cookie provider implementation#49382
Merged
codebytere merged 3 commits intomainfrom Jan 14, 2026
Merged
fix: revert os_crypt async cookie provider implementation#49382codebytere merged 3 commits intomainfrom
codebytere merged 3 commits intomainfrom
Conversation
clavin
approved these changes
Jan 14, 2026
Member
clavin
left a comment
There was a problem hiding this comment.
Looks great, thanks for fixing this!!
I found no other changes depend on this one in a quick search. Fast-tracking for E40 stable release.
codebytere
approved these changes
Jan 14, 2026
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #49384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow up to #49371
Fixes #49383
M144 changed the default cookie encryption and cookie provider logic to use OS_Crypt Async, rather than Sync. Originally, we had landed PRs to add new cookie providers cross-platform, following Chrome's upstream implementation. However, we will need to land additional async logic changes to match the new providers, which will be a larger refactor/chunk of work than simply plumbing through to the providers. See #49054 for what that work might look like.
In lieu of that, we've decided to revert the breaking sync -> async change for Chrome M144/Electron 40, in order to ensure compatibility while we make the needed changes. This PR patches out that change - this patch can be removed when the new work lands, targeting Electron 41. This PR also reverts two previous fix forwards that no longer apply.
Fix can be tested using this test repo: https://github.com/VerteDinde/cookie-encryption-test
Note: The revert was pulled from this upstream tracking issue. Please review the changes carefully: https://issues.chromium.org/issues/447372315
Checklist
npm testpassesRelease Notes
Notes: Fixed the cookie encryption logic to use the old os_crypt sync implementation present in M142