Skip to content

fix: revert os_crypt async cookie provider implementation#49382

Merged
codebytere merged 3 commits intomainfrom
revert-os-async
Jan 14, 2026
Merged

fix: revert os_crypt async cookie provider implementation#49382
codebytere merged 3 commits intomainfrom
revert-os-async

Conversation

@VerteDinde
Copy link
Copy Markdown
Member

@VerteDinde VerteDinde commented Jan 14, 2026

Description of Change

Follow up to #49371
Fixes #49383

M144 changed the default cookie encryption and cookie provider logic to use OS_Crypt Async, rather than Sync. Originally, we had landed PRs to add new cookie providers cross-platform, following Chrome's upstream implementation. However, we will need to land additional async logic changes to match the new providers, which will be a larger refactor/chunk of work than simply plumbing through to the providers. See #49054 for what that work might look like.

In lieu of that, we've decided to revert the breaking sync -> async change for Chrome M144/Electron 40, in order to ensure compatibility while we make the needed changes. This PR patches out that change - this patch can be removed when the new work lands, targeting Electron 41. This PR also reverts two previous fix forwards that no longer apply.

Fix can be tested using this test repo: https://github.com/VerteDinde/cookie-encryption-test

Note: The revert was pulled from this upstream tracking issue. Please review the changes carefully: https://issues.chromium.org/issues/447372315

Checklist

Release Notes

Notes: Fixed the cookie encryption logic to use the old os_crypt sync implementation present in M142

@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes target/40-x-y PR should also be added to the "40-x-y" branch. labels Jan 14, 2026
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 14, 2026
@VerteDinde VerteDinde changed the title fix: revert os_crypt async fix: revert os_crypt async cookie provider implementation Jan 14, 2026
@clavin clavin added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed new-pr 🌱 PR opened recently labels Jan 14, 2026
Copy link
Copy Markdown
Member

@clavin clavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for fixing this!!

I found no other changes depend on this one in a quick search. Fast-tracking for E40 stable release.

@VerteDinde VerteDinde marked this pull request as ready for review January 14, 2026 01:56
@VerteDinde VerteDinde requested a review from a team as a code owner January 14, 2026 01:56
@codebytere codebytere merged commit 1b2679b into main Jan 14, 2026
112 of 113 checks passed
@codebytere codebytere deleted the revert-os-async branch January 14, 2026 08:34
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Jan 14, 2026

Release Notes Persisted

Fixed the cookie encryption logic to use the old os_crypt sync implementation present in M142

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Jan 14, 2026

I have automatically backported this PR to "40-x-y", please check out #49384

@trop trop bot added in-flight/40-x-y merged/40-x-y PR was merged to the "40-x-y" branch. and removed target/40-x-y PR should also be added to the "40-x-y" branch. in-flight/40-x-y labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/40-x-y PR was merged to the "40-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cookie Encryption Causes Network Crash on Packaged App Launch

3 participants