fix: restore AXDocument accessibility attribute for representedFilename on macOS#49418
Merged
codebytere merged 1 commit into39-x-yfrom Jan 19, 2026
Conversation
…me on macOS Starting from Chromium 134.0.6989.0 (Electron 35.0.0-beta.5), the NativeWidgetMacNSWindow class overrides accessibilityDocument to return the web content URL from the accessibility tree, but doesn't fall back to NSWindow's default behavior when that URL is empty. This broke Electron's setRepresentedFilename() API - the file path was still set on the NSWindow, but no longer exposed via the AXDocument accessibility attribute that screen readers use. This fix adds an accessibilityDocument override in ElectronNSWindow that checks representedFilename first, falling back to Chromium's behavior for web content URLs. Fixes: https://github.com/electron/electron/issues/XXXXX Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Daniel Gräfe <Daniel.Alm@ForumD.net>
4 tasks
trop
bot
added
39-x-y
backport
codebytere
approved these changes
Jan 16, 2026
codebytere
deleted the
trop/39-x-y-bp-fix-restore-axdocument-accessibility-attribute-for-representedfilename-on-macos-1768555656170
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49346
See that PR for details.
Notes: Fixed
setRepresentedFilename()not settingAXDocumentaccessibility attribute on macOS.