Conversation
codebytere
added
semver/patch
codebytere
force-pushed
the
fix-dock-menus
branch
from
2ed3fd5 to
84c8eb5
Compare
codebytere
force-pushed
the
fix-dock-menus
branch
from
84c8eb5 to
03a06eb
Compare
jkleinsc
approved these changes
Feb 2, 2026
|
Release Notes Persisted
|
This was referenced Feb 2, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #49624 |
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #49625 |
trop
bot
removed
the
target/40-x-y
Contributor
|
I have automatically backported this PR to "39-x-y", please check out #49626 |
Contributor
|
I have automatically backported this PR to "38-x-y", please check out #49627 |
trop
bot
added
merged/41-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #49573
Fixes dock menu not properly supporting enabled, checked, and icon MenuItem properties. The issue was that
menuWillOpen:isn't called by macOS for dock menus before they are displayed. The enabled, checked, and hidden states were only being applied inrefreshMenuTree, which is called frommenuWillOpen:. Since that delegate method doesn't fire for dock menus, the state was never applied.This PR explicitly calls
refreshMenuTreein applicationDockMenu:before returning the menu to macOS, ensuring the current model state is applied.cc @Kilian
Checklist
npm testpassesRelease Notes
Notes: Fixed dock menu items not respecting enabled and checked properties on macOS.