fix: remove menu observer before destroying menu_controller_#49658
Merged
codebytere merged 2 commits into41-x-yfrom Feb 4, 2026
Conversation
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
6 tasks
trop
bot
added
41-x-y
backport
codebytere
approved these changes
Feb 4, 2026
codebytere
deleted the
trop/41-x-y-bp-fix-remove-menu-observer-before-destroying-menu_controller_-1770217877552
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #49648
See that PR for details.
Notes: Fixed an application crash on MacOS where the menu observer was not being properly removed before garbage collection.