Merged
Conversation
Previously, when trashItemAtURL: failed (e.g. on network shares or under app translocation), the code fell back to constructing an AppleScript that interpolated the bundle path directly into a string literal via %@ with no escaping. This was fragile and unnecessary — trashItemAtURL: has been the standard API since 10.8 and covers the relevant cases. The fix simply removes the AppleScript fallback entirely, so Trash() now returns the result of trashItemAtURL: directly. Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
4 tasks
trop
bot
added
38-x-y
backport
ckerr
approved these changes
Mar 4, 2026
ckerr
deleted the
trop/38-x-y-bp-chore-remove-applescript-from-trash-1772623007039
branch
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50044
See that PR for details.
Notes: none