fix: resolve target bundle path once at start of install#50765
Merged
jkleinsc merged 1 commit intoApr 8, 2026
Conversation
Resolve the Squirrel.Mac target bundle URL to a canonical path once at the top of -[SQRLInstaller installRequest:] and use it for every step of the install chain, rejecting requests whose path is not already canonical. When running with elevated privileges, additionally require the target to be the application bundle that contains the installer. SQRLUpdater now writes the resolved bundle URL so the serialized request is canonical by construction. Co-authored-by: Samuel Attard <sam@electronjs.org>
trop
Bot
added
42-x-y
backport
MarshallOfSound
approved these changes
Apr 7, 2026
jkleinsc
deleted the
trop/42-x-y-bp-fix-resolve-target-bundle-path-once-at-start-of-install-1775527863215
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #50745
See that PR for details.
Notes: Fixed an issue where the Squirrel.Mac installer could resolve the target bundle path to different locations at different stages of an install.