fix: return numeric blksize and blocks from asar fs.stat#50825
Merged
Conversation
clavin
added
bug 🪲
semver/patch
Previously, `fs.stat` on files inside `.asar` archives returned `undefined` for `blksize` and `blocks`, violating the Node.js API contract where these fields must be `number | bigint`. Use `4096` for `blksize` (matching the convention used by `memfs` and the proposed `node:vfs` module in nodejs/node#61478) and compute `blocks` as `ceil(size / 512)` (standard 512-byte block units). Fixes #42686 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
clavin
force-pushed
the
clavin/asar-stat-blksize-blocks
branch
from
bdf33ba to
7b653fe
Compare
dsanders11
approved these changes
Apr 9, 2026
codebytere
approved these changes
Apr 9, 2026
|
Release Notes Persisted
|
This was referenced Apr 10, 2026
Contributor
|
I have automatically backported this PR to "40-x-y", please check out #50875 |
trop
Bot
added
in-flight/40-x-y
and removed
target/40-x-y
Contributor
|
I have automatically backported this PR to "41-x-y", please check out #50876 |
Contributor
|
I have automatically backported this PR to "42-x-y", please check out #50877 |
trop
Bot
added
in-flight/41-x-y
in-flight/42-x-y
merged/41-x-y
trop
Bot
added
merged/42-x-y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
fs.staton files inside.asararchives returnedundefinedforblksizeandblocks, breaking the soundness ofnode:fstypes expectingnumber | bigint.This change sets
blksize: 4096and computesblocks: Math.ceil(size / 512). This happens to align with the proposednode:vfsmodule (nodejs/node#61478). Added a test to continue validating the general propertytypeof asar[key] === typeof real[key].Fixes #42686
Checklist
npm testpassesRelease Notes
Notes: Fixed
fs.staton files inside asar archives returningundefinedforblksizeandblocksinstead of numeric values.