Conversation
Chromium's net::HttpRequestHeaders::SetHeader() uses CHECK() to enforce valid header names and values, which causes a fatal crash if the caller passes invalid strings. When users modify requestHeaders in the onBeforeSendHeaders callback with invalid header names (e.g. containing spaces) or invalid header values (e.g. containing CRLF), the gin::Converter<net::HttpRequestHeaders>::FromV8() calls SetHeader() directly, triggering the CHECK and crashing the process. This change adds pre-validation using net::HttpUtil::IsValidHeaderName() and net::HttpUtil::IsValidHeaderValue() before calling SetHeader(), silently skipping invalid headers instead of crashing. Co-authored-by: loufulton <loufulton.cz@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: loufultoncz-coder <loufulton.cz@gmail.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: loufultoncz-coder <loufulton.cz@gmail.com>
7 tasks
trop
Bot
added
42-x-y
backport
jkleinsc
approved these changes
Apr 28, 2026
jkleinsc
deleted the
trop/42-x-y-bp-fix-validate-header-name-and-value-in-webrequest-onbeforesendheaders-1777383506338
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51340
See that PR for details.
Notes: Fixed a crash when providing invalid HTTP header names or values in the
webRequest.onBeforeSendHeaders()callback