Conversation
The `<geolocation>` HTML element looks up IDS_PERMISSION_REQUEST_GEOLOCATION via ResourceBundle::GetLocalizedString(). These string IDs are defined in third_party/blink/public/strings/permission_element_strings.grd. Electron didn't include that in its pak file, causing CHECK(!data->empty()). Ths PR adds the per-locale permission_element_strings paks and the aggregated permission_element_generated_strings pak to electron_paks.gni. This matches how it's done in `chrome/chrome_repack_locales.gni` and in `chrome/chrome_paks.gni`. Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5907626 Co-authored-by: Charles Kerr <charles@charleskerr.com>
6 tasks
trop
Bot
added
42-x-y
backport
ckerr
approved these changes
Apr 28, 2026
|
Release Notes Persisted
|
ckerr
deleted the
trop/42-x-y-bp-fix-include-permission-element-string-resources-in-locale-paks-1777400739259
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51346
See that PR for details.
Notes: Fixed a renderer crash when a page uses the
<geolocation>HTML element.