test: await did-create-window assertion in child close test#51518
Merged
ckerr merged 1 commit intoMay 6, 2026
Conversation
The async handler inside .on('did-create-window') was never awaited
by the test function, so Mocha marked the test as passed before the
handler ran. Fix this by awaiting the event.
Co-authored-by: Charles Kerr <charles@charleskerr.com>
6 tasks
trop
Bot
added
41-x-y
backport
ckerr
approved these changes
May 6, 2026
ckerr
deleted the
trop/41-x-y-bp-test-await-did-create-window-assertion-in-child-close-test-1778075230349
branch
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51515
See that PR for details.
Notes: none.