fix: ship IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON and allow overriding it#51595
Merged
Conversation
Pack device/fido strings into the locale .pak files so
IDS_WEBAUTHN_TOUCH_ID_PROMPT_REASON ("verify your identity on $1") is
present at runtime. Previously the resource was never repacked, so the
macOS Touch ID prompt for WebAuthn requests crashed when looking up the
missing IDS string.
Also lets apps override the prompt text via
configureWebAuthn({ touchID: { promptReason } }) using
ResourceBundle::OverrideLocaleStringResource. An optional $1 placeholder
is replaced with the relying party ID; without it the string is used
verbatim.
Co-authored-by: Sam Attard <sattard@anthropic.com>
gn check does not evaluate preprocessor conditionals, so it flags the mac-only #include of fido_strings.h on Linux/Windows even though the include is behind BUILDFLAG(IS_MAC). Depend on //device/fido/strings on all platforms to satisfy the header check. Co-authored-by: Sam Attard <sattard@anthropic.com>
5 tasks
trop
Bot
added
43-x-y
backport
VerteDinde
approved these changes
May 12, 2026
VerteDinde
deleted the
trop/43-x-y-bp-fix-ship-ids_webauthn_touch_id_prompt_reason-and-allow-overriding-it-1778612912424
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51592
See that PR for details.
Notes: Fixed a crash in the macOS Touch ID WebAuthn prompt caused by a missing string resource, and added
touchID.promptReasontoapp.configureWebAuthn()to customize the prompt text.