fix: make heap snapshot OOM test allocate faster#51631
Draft
ckerr wants to merge 1 commit into
Draft
Conversation
1. The oom-grow.js fixture triggers OOM to test v8.setHeapSnapshotNearHeapLimit. At ~1KB/tick it needs ~50K iterations to fill 50MB, but V8 (43aa3906777, --late-heap-limit-check) now defers limit checks, so the process never OOMs within the 30s timeout. Fix by allocating 1MB/tick to reach OOM faster. 2. Change the 'max-old-space-size' from 50 MB to 20 MB to try to exhaust the memory pool faster. 3. Add '--no-late-heap-limit-check' to try to undo https://chromium-review.googlesource.com/c/v8/v8/+/6919127 which *may* be making this test flake. Co-Authored-By: John Kleinschmidt <jkleinsc@github.com> Co-Authored-By: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com> Co-Authored-By: GitHub Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix a timeout CI flake in
utilityProcess module behavior supports generating snapshots via v8.setHeapSnapshotNearHeapLimit:The oom-grow.js fixture triggers OOM to test v8.setHeapSnapshotNearHeapLimit. At ~1KB/tick it needs ~50K iterations to fill 50MB, but V8 (43aa3906777,
--late-heap-limit-check) now defers limit checks, so the process never OOMs within the 30s timeout. Fix by allocating 1MB/tick to reach OOM faster.Change the 'max-old-space-size' from 50 MB to 20 MB to try to exhaust the memory pool faster.
Add '--no-late-heap-limit-check' to try to undo https://chromium-review.googlesource.com/c/v8/v8/+/6919127 which may be contributing to this flake.
Sample CI failure:
Checklist
npm testpassesRelease Notes
Notes: none.