build: restore CHROMIUM_BUILDTOOLS_PATH in devcontainer config#51654
Merged
Conversation
jkleinsc
approved these changes
May 19, 2026
|
No Release Notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Follow-up to #51558 to fix the failing codespaces prebuilds. This is an edge case because we hand roll a config here, and
build-toolsis still includingCHROMIUM_BUILDTOOLS_PATHin configs and just ignoring it if the conditions are met. The condition check can't work withoutCHROMIUM_BUILDTOOLS_PATHin the config IF there's also no sync'd checkout (to create.gclient).We'll remove this from the hand rolled config in the future when
build-toolsdrops the conditional check for upstreamdepot_toolssupport.Checklist
Release Notes
Notes: none