build: enable ThinLTO link-time optimization for the main binary#51820
Merged
Conversation
Chromium applies the thinlto_optimize_default config to all targets by default, which passes --lto-O0 (Windows: /opt:lldlto=0) to the linker -- i.e. no optimization is performed during the ThinLTO link step. Chrome opts its main binaries (chrome executable, chrome.dll, Chrome Framework) into the thinlto_optimize_max config to get full link-time optimization, but Electron never did, so release builds of Electron were linked with --lto-O0 and lost most of the benefit of ThinLTO and PGO. Swap in thinlto_optimize_max for electron_app (Linux/Windows) and electron_framework (macOS), exactly like chrome/BUILD.gn does for its equivalent targets. Co-authored-by: Sam Attard <sattard@anthropic.com>
5 tasks
MarshallOfSound
approved these changes
Jun 1, 2026
MarshallOfSound
deleted the
trop/43-x-y-bp-build-enable-thinlto-link-time-optimization-for-the-main-binary-1780323796089
branch
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #51809
See that PR for details.
Notes: Improved performance of Linux and Windows release builds by enabling ThinLTO link-time optimization for the main Electron binary.